Fixes bug where users without read access on a creds org cannot edit the cred #6241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…missions on the credentials org would be denied access to the form in the UI.
|
Build failed.
|
|
recheck |
jakemcdermott
approved these changes
Mar 10, 2020
| @@ -72,7 +72,7 @@ function AddEditCredentialsController ( | |||
| vm.form.credential_type._displayValue = credentialType.get('name'); | |||
| vm.isTestable = (isEditable && credentialType.get('kind') === 'external'); | |||
|
|
|||
| if (credential.get('related.input_sources.results.length' > 0)) { | |||
| if (credential.get('related.input_sources.results').length > 0) { | |||
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
What was happening here was that a request was being made in the resolve block for the edit state that would go out and fetch the organization. This request failed and we were falling into a
catchwhich threw an error and stopped the transition to the state.We actually don't need to go out and fetch the org - we have some basic org info in the
summary_fieldsof the credential. These changes use the condensed object from thesummary_fieldsto populate the model and mitigate the need for a GET.Once I got the form rendering, I noticed that the credential type field was disabled. This was due to a syntax error when fetching
input_sourcesfrom the model.ISSUE TYPE
COMPONENT NAME