-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update openapi schema for rule audits to include filter params #1194
Conversation
c57cd43
to
cc336a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1194 +/- ##
==========================================
+ Coverage 93.33% 93.35% +0.01%
==========================================
Files 261 262 +1
Lines 14939 14982 +43
==========================================
+ Hits 13944 13987 +43
Misses 995 995
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e2e test run with updated client: https://github.com/ansible/eda-server/actions/runs/12896272262 |
cc336a1
to
2576147
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the idea and it is a LGTM, but I also think that generate_query_params
function should have unit tests.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Rule Audit
Audit Action
Audit Event