feat: [AAP-38978] - improve rulebook activations logs messages #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1195 +/- ##
==========================================
+ Coverage 93.41% 93.47% +0.06%
==========================================
Files 264 268 +4
Lines 15118 15268 +150
==========================================
+ Hits 14122 14272 +150
Misses 996 996
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hsong-rh
force-pushed
the
change_log_message
branch
4 times, most recently
from
de6766b to
c51568b
Compare
hsong-rh
force-pushed
the
change_log_message
branch
2 times, most recently
from
5d8b070 to
a18e058
Compare
src/aap_eda/core/migrations/0056_rulebookprocesslog_log_created_at_and_more.py
Outdated
Show resolved
Hide resolved
src/aap_eda/core/migrations/0056_rulebookprocesslog_log_created_at_and_more.py
Outdated
Show resolved
Hide resolved
hsong-rh
force-pushed
the
change_log_message
branch
6 times, most recently
from
c31a247 to
1de7096
Compare
zkayyali812
previously approved these changes
Jan 30, 2025
hsong-rh
force-pushed
the
change_log_message
branch
4 times, most recently
from
d2a65f2 to
a1a9318
Compare
tests/integration/core/migrations/test_0056_parse_log_entries.py
Outdated
Show resolved
Hide resolved
hsong-rh
force-pushed
the
change_log_message
branch
2 times, most recently
from
2fe0f86 to
2db8c24
Compare
hsong-rh
force-pushed
the
change_log_message
branch
from
2db8c24 to
ca61489
Compare
|
Alex-Izquierdo
approved these changes
Feb 3, 2025
|
@hsong-rh thanks for attending all my comments. |
No problem, thank you for your reviews |
mkanoor
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/AAP-38978