Include vars for ansible version >= 2.6 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK |
fabianvf
requested changes
May 22, 2018
templates/service.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| --- | |||
|
|
|||
| apiVersion: v1 | |||
There was a problem hiding this comment.
This one is always v1, don't think you need a parameter
templates/pvc.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| --- | |||
|
|
|||
| apiVersion: v1 | |||
| apiVersion: {{ pvc_api_version }} | |||
There was a problem hiding this comment.
This one is always v1, don't think you need a parameter
| @@ -14,6 +14,10 @@ | |||
| set_fact: | |||
| cluster: "{{ 'openshift' if 'openshift' in oc_version.stdout else 'kubernetes' }}" | |||
|
|
|||
| - name: 'Include variables based on ansible version' | |||
| include_vars: ansible_26.yml | |||
There was a problem hiding this comment.
Do you need to import the 25 variables as well?
There was a problem hiding this comment.
I just use them to override 25 variables.
| protocol: TCP | ||
| volumeMounts: | ||
| - name: mediawiki | ||
| mountPath: /persistent | ||
| volumes: | ||
| - name: mediawiki | ||
| persistent_volume_claim: |
There was a problem hiding this comment.
Will these changes work with v1?
There was a problem hiding this comment.
I tested using 2.5 and it still worked.
dymurray
approved these changes
May 23, 2018
fabianvf
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.