Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Various improvements to Object3D #5668

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

maxcapodi78
Copy link
Collaborator

Bug when parsing data for object3d. Wrong group assignment and missing transparency.

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Fixed #5561
Fixed #5567

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

Fixed #5567
Bug when parsing data for object3d. Wrong group assignment and missing transparency.
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 85.23364% with 79 lines in your changes missing coverage. Please review.

Project coverage is 85.14%. Comparing base (8c592a1) to head (81cf704).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5668      +/-   ##
==========================================
- Coverage   85.24%   85.14%   -0.10%     
==========================================
  Files         154      154              
  Lines       60767    60791      +24     
==========================================
- Hits        51802    51763      -39     
- Misses       8965     9028      +63     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import_gds_3d doesn't work in non graphical mode
1 participant