Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Shielding effectiveness extension #5672

Merged
merged 21 commits into from
Jan 31, 2025

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Jan 17, 2025

Description

Compute shielding effectiveness with an extension
Add Hertzian dipole wave excitation

Issue linked

Close #5671
Close #5679

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.20%. Comparing base (df25e9d) to head (ff43f08).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5672      +/-   ##
==========================================
+ Coverage   85.17%   85.20%   +0.03%     
==========================================
  Files         155      156       +1     
  Lines       60833    60979     +146     
==========================================
+ Hits        51812    51958     +146     
  Misses       9021     9021              

maxcapodi78
maxcapodi78 previously approved these changes Jan 30, 2025
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

SMoraisAnsys
SMoraisAnsys previously approved these changes Jan 31, 2025
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left some minor comments

Co-authored-by: Sébastien Morais <[email protected]>
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) January 31, 2025 11:17
@Samuelopez-ansys Samuelopez-ansys merged commit 4fca434 into main Jan 31, 2025
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/shielding_effectiveness branch January 31, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hertzina Dipole Wave Excitation Shielding effectiveness extension
3 participants