-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Shielding effectiveness extension #5672
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5672 +/- ##
==========================================
+ Coverage 85.17% 85.20% +0.03%
==========================================
Files 155 156 +1
Lines 60833 60979 +146
==========================================
+ Hits 51812 51958 +146
Misses 9021 9021 |
# Conflicts: # tests/system/solvers/test_45_workflows.py
…to feat/shielding_effectiveness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left some minor comments
Co-authored-by: Sébastien Morais <[email protected]>
467ca3e
Co-authored-by: Sébastien Morais <[email protected]>
For more information, see https://pre-commit.ci
…to feat/shielding_effectiveness
Description
Compute shielding effectiveness with an extension
Add Hertzian dipole wave excitation
Issue linked
Close #5671
Close #5679
Checklist