Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Load numpy lazily #5673

Merged
merged 1 commit into from
Jan 17, 2025
Merged

FIX: Load numpy lazily #5673

merged 1 commit into from
Jan 17, 2025

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Jan 17, 2025

Description

Running some PyAEDT tests in Linux with numpy>=2.Y leads to errors when a test requires to load a Desktop and then uses PyEDB and tries to load .NET Core.

This changes will ensure that if one uses ansys.aedt.core, numpy is not loaded by default before the Desktop.
Otherwise, there is a side effect and .NET Core can't be loaded...

This should be further investigated.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.23%. Comparing base (11e2fdd) to head (2c30584).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5673      +/-   ##
==========================================
- Coverage   85.23%   85.23%   -0.01%     
==========================================
  Files         154      154              
  Lines       60764    60763       -1     
==========================================
- Hits        51795    51789       -6     
- Misses       8969     8974       +5     

@SMoraisAnsys SMoraisAnsys merged commit 5414fb3 into main Jan 17, 2025
43 checks passed
@SMoraisAnsys SMoraisAnsys deleted the fix/dotnet-load-with-numpy-gt-2 branch January 17, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants