Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add distributed filters topology #5687

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

ramin4667
Copy link
Contributor

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@ramin4667 ramin4667 changed the title Feat add distributed filters topology FEAT: Add distributed filters topology Jan 22, 2025
@github-actions github-actions bot added testing Anything related to testing enhancement New features or code improvements labels Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.25%. Comparing base (8c592a1) to head (ba072e1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5687   +/-   ##
=======================================
  Coverage   85.24%   85.25%           
=======================================
  Files         154      154           
  Lines       60767    60767           
=======================================
+ Hits        51802    51806    +4     
+ Misses       8965     8961    -4     

@ramin4667
Copy link
Contributor Author

Test coverage results are attached:

---------- coverage: platform win32, python 3.11.8-final-0 -----------
Name Stmts Miss Cover Missing

src\ansys\aedt\core\filtersolutions_core_init_.py 12 1 92% 41
src\ansys\aedt\core\filtersolutions_core\attributes.py 880 41 95% 845-846, 850, 951-952, 956, 968-969, 973, 985-988, 992, 1006-1009, 1013, 1027-1028, 1032, 1044-1045, 1049, 1150-1153, 1157-1158, 1168-1171, 1175-1176, 1188-1193, 1197-1198
src\ansys\aedt\core\filtersolutions_core\distributed_topology.py 478 0 100%
src\ansys\aedt\core\filtersolutions_core\dll_interface.py 67 10 85% 53-66
src\ansys\aedt\core\filtersolutions_core\export_to_aedt.py 863 21 98% 833-835, 1224-1225, 1229-1230, 1281, 1316, 1350, 1483-1484, 1494-1497, 1501-1502, 1631, 1665-1666
src\ansys\aedt\core\filtersolutions_core\graph_setup.py 53 0 100%
src\ansys\aedt\core\filtersolutions_core\ideal_response.py 171 0 100%
src\ansys\aedt\core\filtersolutions_core\lumped_nodes_and_leads.py 106 0 100%
src\ansys\aedt\core\filtersolutions_core\lumped_parasitics.py 97 0 100%
src\ansys\aedt\core\filtersolutions_core\lumped_termination_impedance_table.py 142 0 100%
src\ansys\aedt\core\filtersolutions_core\lumped_topology.py 314 0 100%
src\ansys\aedt\core\filtersolutions_core\multiple_bands_table.py 59 0 100%
src\ansys\aedt\core\filtersolutions_core\optimization_goals_table.py 90 18 80% 309-316, 326-335, 344-345
src\ansys\aedt\core\filtersolutions_core\transmission_zeros.py 76 0 100%

TOTAL 3408 91 97%

@myoung301
Copy link
Contributor

Looking at the coverage results, there are some lines that aren't covered. Are there some tests missing or what did the coverage check reveal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants