Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove version property from model manifest #116

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Remove version property from model manifest #116

merged 1 commit into from
Dec 12, 2024

Conversation

awoimbee
Copy link
Collaborator

@awoimbee awoimbee self-assigned this Dec 12, 2024
@awoimbee awoimbee marked this pull request as ready for review December 12, 2024 12:55
@awoimbee awoimbee requested review from yias and a team as code owners December 12, 2024 12:55
@awoimbee awoimbee requested review from tmpbeing and removed request for a team December 12, 2024 12:55
yias
yias approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@yias yias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better like that, thanks!

@awoimbee awoimbee merged commit f250b0a into main Dec 12, 2024
31 checks passed
@awoimbee awoimbee deleted the aw/rm-version-from-model-manifest branch December 12, 2024 14:56
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (639a117) to head (344f81f).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@     Coverage Diff     @@
##   main   #116   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yias yias yias approved these changes

@tmpbeing tmpbeing Awaiting requested review from tmpbeing tmpbeing is a code owner automatically assigned from ansys/pysimai-maintainers

Assignees

@awoimbee awoimbee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awoimbee @yias