Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to set Train/Validation/Test subset on training data #42

Conversation

kliment-slice
Copy link
Contributor

[sc-17795]
set_subset method added to TrainingData class, subset enum type. Tested and verified.

@github-actions github-actions bot added the enhancement New features or code improvements label Apr 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.82%. Comparing base (ea5494c) to head (0513d88).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   80.43%   80.82%   +0.38%     
==========================================
  Files          42       43       +1     
  Lines        2208     2263      +55     
==========================================
+ Hits         1776     1829      +53     
- Misses        432      434       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yias yias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few comments from my side :)

src/ansys/simai/core/api/training_data.py Show resolved Hide resolved
src/ansys/simai/core/data/training_data.py Outdated Show resolved Hide resolved
src/ansys/simai/core/data/types.py Show resolved Hide resolved
src/ansys/simai/core/data/training_data.py Outdated Show resolved Hide resolved
tests/test_training_data.py Outdated Show resolved Hide resolved
src/ansys/simai/core/data/training_data.py Outdated Show resolved Hide resolved
src/ansys/simai/core/data/training_data.py Outdated Show resolved Hide resolved
tests/test_training_data.py Outdated Show resolved Hide resolved
Copy link
Contributor

@yias yias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one more thing for the exception, but it looks fine to me.

src/ansys/simai/core/api/training_data.py Outdated Show resolved Hide resolved
src/ansys/simai/core/api/training_data.py Outdated Show resolved Hide resolved
src/ansys/simai/core/api/training_data.py Outdated Show resolved Hide resolved
src/ansys/simai/core/data/training_data.py Outdated Show resolved Hide resolved
src/ansys/simai/core/data/types.py Show resolved Hide resolved
Copy link
Collaborator

@awoimbee awoimbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect !

@kliment-slice kliment-slice merged commit 364bf6f into main Apr 25, 2024
31 checks passed
@kliment-slice kliment-slice deleted the feature/sc-17795/allow-user-to-set-train-validation-test-subset branch April 25, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants