Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug renderFooter #1294

Merged
merged 1 commit into from
May 10, 2017
Merged

Conversation

himStone
Copy link

@himStone himStone commented May 10, 2017

First of all, thanks for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

This change is Reviewable

@mention-bot
Copy link

@bccsafe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yiminghe, @silentcloud and @warmhug to be potential reviewers.

@codecov
Copy link

codecov bot commented May 10, 2017

Codecov Report

Merging #1294 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1294   +/-   ##
=======================================
  Coverage   61.82%   61.82%           
=======================================
  Files         219      219           
  Lines        4155     4155           
  Branches     1222     1222           
=======================================
  Hits         2569     2569           
  Misses       1585     1585           
  Partials        1        1
Flag Coverage Δ
#rn 63.12% <0%> (ø) ⬆️
#web 60.5% <ø> (ø) ⬆️
Impacted Files Coverage Δ
components/list/index.tsx 84.37% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d369ecb...fda4d66. Read the comment docs.

@paranoidjk paranoidjk merged commit 6ad399d into ant-design:master May 10, 2017
@himStone himStone deleted the fix-bug-renderFooter branch May 10, 2017 05:19
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this pull request Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants