feat: add preact-snapshot-test. #1306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paranoidjk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yiminghe, @pingan1927 and @silentcloud to be potential reviewers. |
paranoidjk
changed the title
cncolder
reviewed
May 12, 2017
tests/shared/demoTest.js
Outdated
| @@ -23,6 +41,14 @@ export function webDemoTest(component, options = {}) { | |||
| }); | |||
| } | |||
|
|
|||
| export function webDemoTest(...args) { | |||
| if (process.env.TEST_ENV === 'preact') { | |||
There was a problem hiding this comment.
这里和 npm scripts 不一致。
"test:web-preact": "TEST_ENV=PREACT jest --config .jest.preact.json",
个人觉得应该像 NODE_ENV 一样采用小写。
There was a problem hiding this comment.
ok，大小写倒不限制，主要是手滑两边没统一...
paranoidjk
force-pushed
the
add-preact-snapshot
branch
from
3353027 to
062032a
Compare
paranoidjk
changed the title
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #1306 +/- ##
=======================================
Coverage 63.12% 63.12%
=======================================
Files 100 100
Lines 2099 2099
Branches 654 654
=======================================
Hits 1325 1325
Misses 774 774
Continue to review full report at Codecov.
|
paranoidjk
force-pushed
the
add-preact-snapshot
branch
from
4c4085c to
acf8a58
Compare
This was referenced May 12, 2017
|
snapshot 可能无法覆盖 trigger 和弹层的情况。 |
paranoidjk
force-pushed
the
master
branch
2 times, most recently
from
794ec1b to
bd9b23e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1267
from https://github.com/adriantoine/enzyme-to-json#user-content-serializer:
First of all, thanks for your contribution! :-)
Please makes sure these boxes are checked before submitting your PR, thank you!
npm run lintand fix those errors before submitting in order to keep consistent code style.This change is