Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor Button tsx #1327

Merged
merged 1 commit into from
May 17, 2017
Merged

Conversation

himStone
Copy link

@himStone himStone commented May 16, 2017

First of all, thanks for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

#1212


This change is Reviewable

@mention-bot
Copy link

@bccsafe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @silentcloud, @warmhug and @yiminghe to be potential reviewers.

@codecov
Copy link

codecov bot commented May 16, 2017

Codecov Report

Merging #1327 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1327      +/-   ##
=========================================
+ Coverage   61.79%   61.8%   +<.01%     
=========================================
  Files         219     219              
  Lines        4164    4165       +1     
  Branches     1225    1225              
=========================================
+ Hits         2573    2574       +1     
  Misses       1590    1590              
  Partials        1       1
Flag Coverage Δ
#rn 63.22% <33.33%> (+0.01%) ⬆️
#web 60.35% <100%> (ø) ⬆️
Impacted Files Coverage Δ
components/button/index.web.tsx 96.77% <100%> (ø) ⬆️
components/button/index.tsx 90% <33.33%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665e398...705ab80. Read the comment docs.

@himStone himStone force-pushed the refactor-button-tsx branch from 1f80870 to 705ab80 Compare May 16, 2017 15:54
@paranoidjk paranoidjk merged commit fc5eeaf into ant-design:master May 17, 2017
@himStone himStone deleted the refactor-button-tsx branch May 17, 2017 01:56
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this pull request Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants