Fix search bar #1621
Merged
Fix search bar #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pingan1927, thanks for your PR! By analyzing the history of the files in this pull request, we identified @warmhug, @yiminghe and @silentcloud to be potential reviewers. |
afc163
reviewed
Jul 28, 2017
components/search-bar/index.web.tsx
Outdated
| (this.refs as any).searchInput.focus(); | ||
| this.componentDidUpdate(); | ||
| }, 300); | ||
| } |
There was a problem hiding this comment.
哈哈，我也觉得怪怪地，更优雅的写法有吗？
There was a problem hiding this comment.
测测没问题就好。 只是这种写 alipay agent 特殊代码的做法 能少还是少点好。
There was a problem hiding this comment.
const ua = navigator.userAgent;
if (ua.indexOf('AlipayClient') >= 0 && (ua.match(/Android/i) || ua.indexOf('AM') < 0)) {
// xxx
}
Codecov Report
@@ Coverage Diff @@
## master #1621 +/- ##
==========================================
- Coverage 66.19% 66.16% -0.03%
==========================================
Files 228 228
Lines 4423 4425 +2
Branches 1157 1158 +1
==========================================
Hits 2928 2928
- Misses 1494 1496 +2
Partials 1 1
Continue to review full report at Codecov.
|
warmhug
approved these changes
Jul 28, 2017
components/search-bar/index.web.tsx
Outdated
| (this.refs as any).searchInput.focus(); | ||
| this.componentDidUpdate(); | ||
| }, 300); | ||
| } |
There was a problem hiding this comment.
测测没问题就好。 只是这种写 alipay agent 特殊代码的做法 能少还是少点好。
marswong
pushed a commit
to marswong/ant-design-mobile
that referenced
this pull request
Jul 28, 2017
* fix ant-design#1609 * update search-bar doc * optimize code * optimize code
lixiaoyang1992
pushed a commit
to lixiaoyang1992/ant-design-mobile
that referenced
this pull request
Apr 26, 2018
* fix ant-design#1609 * update search-bar doc * optimize code * optimize code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1609
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
npm run lintand fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :
This change is