Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support locale #2669

Merged
merged 2 commits into from
Jun 26, 2018
Merged

Support locale #2669

merged 2 commits into from
Jun 26, 2018

Conversation

ziluo
Copy link
Contributor

@ziluo ziluo commented Jun 25, 2018

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

This change is Reviewable

@ghost ghost assigned ziluo Jun 25, 2018
@ghost ghost added the In Progress label Jun 25, 2018
@ziluo ziluo requested review from warmhug, doxiaodong and KgTong June 25, 2018 09:05
@codecov
Copy link

codecov bot commented Jun 25, 2018

Codecov Report

Merging #2669 into master will increase coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2669      +/-   ##
==========================================
+ Coverage   59.24%   59.24%   +<.01%     
==========================================
  Files          90       92       +2     
  Lines        2191     2201      +10     
  Branches      626      626              
==========================================
+ Hits         1298     1304       +6     
- Misses        887      891       +4     
  Partials        6        6
Flag Coverage Δ
#web 59.24% <60%> (ø) ⬆️
Impacted Files Coverage Δ
components/locale-provider/sv_SE.tsx 0% <0%> (ø) ⬆️
components/menu/locale/sv_SE.tsx 0% <0%> (ø)
components/pull-to-refresh/locale/sv_SE.tsx 0% <0%> (ø)
components/menu/index.tsx 69.9% <100%> (+0.9%) ⬆️
components/pull-to-refresh/index.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd23d03...2a7994b. Read the comment docs.

@KgTong KgTong merged commit c2ae660 into master Jun 26, 2018
@ziluo ziluo deleted the support_local branch June 26, 2018 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants