Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(InputItem): Adjust the caret position of the formatted value #2854

Merged
merged 3 commits into from
Dec 28, 2018

Conversation

zack24q
Copy link
Contributor

@zack24q zack24q commented Sep 20, 2018

尝试优化受控组件在变更内容后,光标位置变到最右的问题 (#2840 #1553 #1208 #1162 #1165 #810)

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@ghost ghost assigned zack24q Sep 20, 2018
@ghost ghost added the In Progress label Sep 20, 2018
@codecov
Copy link

codecov bot commented Sep 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@0c3be4a). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2854   +/-   ##
=========================================
  Coverage          ?   60.12%           
=========================================
  Files             ?       92           
  Lines             ?     2237           
  Branches          ?      639           
=========================================
  Hits              ?     1345           
  Misses            ?      886           
  Partials          ?        6
Flag Coverage Δ
#web 60.12% <50%> (?)
Impacted Files Coverage Δ
components/input-item/index.tsx 60.58% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c3be4a...3d1b13b. Read the comment docs.

components/input-item/index.tsx Outdated Show resolved Hide resolved
@zack24q zack24q requested a review from micooz September 24, 2018 08:31
@zack24q zack24q requested a review from doxiaodong December 26, 2018 03:08
@ziluo ziluo merged commit 6db1c19 into master Dec 28, 2018
@ziluo ziluo deleted the fix-input-caret-position branch December 28, 2018 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants