Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #3112 #3113

Merged
merged 1 commit into from
Mar 20, 2019
Merged

fix: #3112 #3113

merged 1 commit into from
Mar 20, 2019

Conversation

chiaweilee
Copy link
Contributor

@chiaweilee chiaweilee commented Mar 9, 2019

#3112

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@44d1835). Click here to learn what that means.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3113   +/-   ##
=========================================
  Coverage          ?   60.41%           
=========================================
  Files             ?       92           
  Lines             ?     2261           
  Branches          ?      651           
=========================================
  Hits              ?     1366           
  Misses            ?      886           
  Partials          ?        9
Flag Coverage Δ
#web 60.41% <83.33%> (?)
Impacted Files Coverage Δ
components/tab-bar/index.tsx 90.32% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d1835...fea936c. Read the comment docs.

@likezero likezero self-assigned this Mar 19, 2019
Copy link
Contributor

@doxiaodong doxiaodong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doxiaodong doxiaodong merged commit 0686667 into ant-design:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants