-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
修复使用TypeScript时Modal onPresss方法缺乏参数定义 #3136
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3136 +/- ##
=========================================
Coverage ? 60.05%
=========================================
Files ? 92
Lines ? 2278
Branches ? 654
=========================================
Hits ? 1368
Misses ? 901
Partials ? 9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no param in onPress callback, see https://github.com/ant-design/ant-design-mobile/blob/master/components/modal/Modal.tsx#L76
The Modal.prompt use the same CallbackOrActions on PropsType when onPress, and it may have param in onPress callback, see https://github.com/ant-design/ant-design-mobile/blob/482bd8e56cd33a6f0f8c24bfc1847a0fbf8134b9/components/modal/prompt.tsx#L157 @doxiaodong |
Sorry, the link is error, here is the right link ant-design-mobile/components/modal/prompt.tsx Line 157 in 482bd8e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)