Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复使用TypeScript时Modal onPresss方法缺乏参数定义 #3136

Merged
merged 3 commits into from
Apr 8, 2019
Merged

修复使用TypeScript时Modal onPresss方法缺乏参数定义 #3136

merged 3 commits into from
Apr 8, 2019

Conversation

helloworldchao
Copy link
Contributor

@helloworldchao helloworldchao commented Mar 23, 2019

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Make sure that you add at least one unit test for the bug which you had fixed.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a458576). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3136   +/-   ##
=========================================
  Coverage          ?   60.05%           
=========================================
  Files             ?       92           
  Lines             ?     2278           
  Branches          ?      654           
=========================================
  Hits              ?     1368           
  Misses            ?      901           
  Partials          ?        9
Flag Coverage Δ
#web 60.05% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a458576...63a975e. Read the comment docs.

Copy link
Contributor

@doxiaodong doxiaodong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@helloworldchao
Copy link
Contributor Author

The Modal.prompt use the same CallbackOrActions on PropsType when onPress, and it may have param in onPress callback, see https://github.com/ant-design/ant-design-mobile/blob/482bd8e56cd33a6f0f8c24bfc1847a0fbf8134b9/components/modal/prompt.tsx#L157 @doxiaodong

@helloworldchao
Copy link
Contributor Author

Sorry, the link is error, here is the right link

return callback(...callbackArgs);
@doxiaodong

Copy link
Contributor

@doxiaodong doxiaodong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doxiaodong doxiaodong merged commit 0a6fd0d into ant-design:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants