-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typescript React import #3179
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3179 +/- ##
=======================================
Coverage 60.05% 60.05%
=======================================
Files 92 92
Lines 2278 2278
Branches 654 654
=======================================
Hits 1368 1368
Misses 901 901
Partials 9 9
Continue to review full report at Codecov.
|
Not enough since |
@doxiaodong There have no effect for developers using |
@ycjcl868 some declare types is defined by rmc-xxx |
What files ? |
Thank you . also change |
@doxiaodong It doesn't matter to developers using |
|
ok, |
package.json
Outdated
@@ -35,6 +35,7 @@ | |||
"babel-runtime": "6.x", | |||
"classnames": "^2.2.1", | |||
"normalize.css": "^7.0.0", | |||
"prop-types": "^15.7.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this. the prop-types
should be chosen by users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3186 这个先合吧, [email protected] 修正后导致 compile 不过了. |
Close #3178.
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :
This change is