Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复Input格式化类型删除时,光标定位问题 #3189

Merged
merged 1 commit into from
Apr 28, 2019

Conversation

sayll
Copy link
Contributor

@sayll sayll commented Apr 26, 2019

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #3189 into master will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3189      +/-   ##
==========================================
+ Coverage   60.05%   60.06%   +<.01%     
==========================================
  Files          92       92              
  Lines        2278     2281       +3     
  Branches      654      655       +1     
==========================================
+ Hits         1368     1370       +2     
- Misses        901      902       +1     
  Partials        9        9
Flag Coverage Δ
#web 60.06% <75%> (ø) ⬆️
Impacted Files Coverage Δ
components/input-item/index.tsx 63.92% <75%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eba6f4...1fec50a. Read the comment docs.

@doxiaodong
Copy link
Contributor

@zack24q

@zack24q zack24q merged commit b10e735 into ant-design:master Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants