Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix drawer #11702

Merged
merged 6 commits into from
Aug 18, 2018
Merged

Fix drawer #11702

merged 6 commits into from
Aug 18, 2018

Conversation

chenshuai2144
Copy link
Contributor

Fix #11583 #11443
Remove pointer-events

@ant-design-bot
Copy link
Contributor

Deploy preview for ant-design ready!

Built with commit 8faadd0

https://deploy-preview-11702--ant-design.netlify.com

afc163
afc163 reviewed Aug 10, 2018
View reviewed changes
components/style/themes/default.less Outdated
@@ -77,6 +77,7 @@
@link-hover-decoration : none;

// Animation
@ease : cubic-bezier(0.7, 0.3, 0.1, 1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个和 ease 毫无联系。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

罗哥起的名字，换成什么合适

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

放在 drawer 里就叫 @drawer-easing 好了

Copy link
Member

@jljsj33 jljsj33 Aug 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这就是 ease ，，不要改名啊，，后续还要加个反向的，，要把组件里的所有动画在窗口里出现或有透明过渡的改成这个。。。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://cubic-bezier.com/#.25,.1,.25,1

这个才是 ease，而且是默认的不用声明。

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 10, 2018 •
edited
Loading

Deploy preview for ant-design ready!

Built with commit 5a66a0a

https://deploy-preview-11702--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Aug 10, 2018 •
edited
Loading

Codecov Report

Merging #11702 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11702   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files         200      200           
  Lines        5171     5171           
  Branches     1454     1454           
=======================================
  Hits         4759     4759           
  Misses        408      408           
  Partials        4        4
Impacted Files Coverage Δ
components/input/Input.tsx 100% <0%> (ø) ⬆️
components/tree/Tree.tsx 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e107b03...5a66a0a. Read the comment docs.

@chenshuai2144
Copy link
Contributor Author

滚动条的 bug 在这里修吧
@jljsj33

@jljsj33
Copy link
Member

jljsj33 commented Aug 10, 2018

你去 featDrawer 那这支拷代码。。。ease 改为 ease-base-out， 新增了个缓动 ease-base-in

@jljsj33
Copy link
Member

jljsj33 commented Aug 10, 2018

image

两个缓动是这样的，，，后继慢慢改组件里面的缓动。。。

yutingzhao1991
yutingzhao1991 reviewed Aug 10, 2018
View reviewed changes
package.json Outdated
@@ -59,7 +59,7 @@
"rc-checkbox": "~2.1.5",
"rc-collapse": "~1.9.0",
"rc-dialog": "~7.2.0",
"rc-drawer": "~1.6.2",
"rc-drawer": "~1.7.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.6 -> 1.7 没有 feature？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有，，只是大改样式的

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK 那今天发掉。

@yutingzhao1991 yutingzhao1991 mentioned this pull request Aug 10, 2018
Merged
@jljsj33
Copy link
Member

jljsj33 commented Aug 16, 2018

叫你把样式全复制过来的，，非要不听，不复制，，，100% 到 auto 是没动画的。。。。。

@chenshuai2144
Copy link
Contributor Author

左边会出来一个奇怪的动画，是不是时机不对？

@chenshuai2144
Copy link
Contributor Author

right 的退出动画 会在左边播放

@jljsj33
Copy link
Member

jljsj33 commented Aug 16, 2018

为什么 spin 的 ci 暴了？？

@chenshuai2144
Copy link
Contributor Author

应该是底层包更新。

@chenshuai2144
Copy link
Contributor Author

可以合了，ie测试了一波，稳

@afc163 afc163 mentioned this pull request Aug 18, 2018
Merged
@picodoth
Copy link
Contributor

所以这个可以合了么，我去看一下 master ci

@picodoth picodoth merged commit 958e8eb into master Aug 18, 2018
@picodoth picodoth deleted the fixDrawer branch August 18, 2018 04:34
@entronad
Copy link

@chenshuai2144
right 的退出动画 会在左边播放
这个问题好像合进master后还没解决，我pull的最新master代码有这个问题

@jljsj33 jljsj33 mentioned this pull request Aug 22, 2018
Merged
@IssueHuntBot IssueHuntBot mentioned this pull request Aug 28, 2018
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jljsj33 jljsj33 jljsj33 left review comments

@yutingzhao1991 yutingzhao1991 yutingzhao1991 left review comments

@afc163 afc163 afc163 left review comments

@picodoth picodoth picodoth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@chenshuai2144 @ant-design-bot @jljsj33 @picodoth @entronad @afc163 @yutingzhao1991