Fix the bug that radio onChange will be overide by radioGroup onChange #14364

ztplz · 2019-01-16T02:47:47Z

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

What's the background?

Describe the source of requirement.

Resolve what problem.
Fix RadioGroup doesn't access Radio's onChange #14353

Related issue link.

API Realization (Optional if not new feature)

Basic thought of solution and other optional proposal.

List final API realization and usage sample.

GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

Does this PR affect user? Which part will be affected?

What will say in changelog?
Fix the bug that radio onChange will be ovrride by radioGroup onChange
修复 radio 的 onChange 事件会被 radioGroup 的 onChange 事件覆盖的 bug

Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

English description

Chinese description (optional)

Self Check before Merge

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

afc163 · 2019-01-16T02:51:55Z

Changelog~

netlify · 2019-01-16T02:55:24Z

Deploy preview for ant-design ready!

Built with commit fc685f0

https://deploy-preview-14364--ant-design.netlify.com

zombieJ · 2019-01-16T07:25:36Z

CI broken, pls check.

ztplz · 2019-01-17T01:24:15Z

@afc163 @zombieJ Done.

codecov · 2019-01-17T01:25:22Z

Codecov Report

Merging #14364 into master will decrease coverage by 0.05%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master   #14364      +/-   ##
==========================================
- Coverage   94.36%    94.3%   -0.06%     
==========================================
  Files         325      325              
  Lines        7094     7099       +5     
  Branches     1750     1752       +2     
==========================================
+ Hits         6694     6695       +1     
- Misses        388      392       +4     
  Partials       12       12

Impacted Files	Coverage Δ
components/radio/radio.tsx	`97.22% <83.33%> (-2.78%)`	⬇️
components/_util/wave.tsx	`84.84% <0%> (-3.04%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7181a...64104bb. Read the comment docs.

codecov · 2019-01-17T01:25:22Z

Codecov Report

Merging #14364 into master will decrease coverage by 0.05%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master   #14364      +/-   ##
==========================================
- Coverage   94.36%    94.3%   -0.06%     
==========================================
  Files         325      325              
  Lines        7094     7099       +5     
  Branches     1750     1752       +2     
==========================================
+ Hits         6694     6695       +1     
- Misses        388      392       +4     
  Partials       12       12

Impacted Files	Coverage Δ
components/radio/radio.tsx	`97.22% <83.33%> (-2.78%)`	⬇️
components/_util/wave.tsx	`84.84% <0%> (-3.04%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7181a...64104bb. Read the comment docs.

codecov · 2019-01-17T01:25:23Z

Codecov Report

Merging #14364 into master will decrease coverage by 0.05%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master   #14364      +/-   ##
==========================================
- Coverage   94.36%    94.3%   -0.06%     
==========================================
  Files         325      325              
  Lines        7094     7099       +5     
  Branches     1750     1752       +2     
==========================================
+ Hits         6694     6695       +1     
- Misses        388      392       +4     
  Partials       12       12

Impacted Files	Coverage Δ
components/radio/radio.tsx	`97.22% <83.33%> (-2.78%)`	⬇️
components/_util/wave.tsx	`84.84% <0%> (-3.04%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7181a...64104bb. Read the comment docs.

codecov · 2019-01-17T01:25:23Z

Codecov Report

Merging #14364 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #14364      +/-   ##
==========================================
+ Coverage   94.36%   94.39%   +0.03%     
==========================================
  Files         325      325              
  Lines        7094     7099       +5     
  Branches     1750     1752       +2     
==========================================
+ Hits         6694     6701       +7     
+ Misses        388      386       -2     
  Partials       12       12

Impacted Files	Coverage Δ
components/radio/radio.tsx	`100% <100%> (ø)`	⬆️
components/upload/UploadList.tsx	`89.74% <0%> (+1.7%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7181a...fc685f0. Read the comment docs.

ztplz · 2019-01-17T01:31:35Z

加个测试

components/radio/__tests__/group.test.js

components/radio/radio.tsx

ztplz · 2019-01-18T03:29:42Z

@zombieJ Done.

* master: (45 commits) Add type definitions for Steps.Step (#14468) add select check to fix edge wave issue (#14469) Fix for Pagination ellipsis misalignment (#14473) change sentry id ✅ Add sentry in ant.design 💄 New Sketch resources! fix transfer ref (#14441) Add onMouseEnter and onMouseLeave for Menu Item (#14454) update snapshot (#14467) 📝 beautify code style in documentation (#14457) Updating type: TreeSelectProps.getPopupContainer (#14443) change error version 3.12.4 changelog (#14436) Format Fix the bug that radio onchange will be ovrride by radioGroup onchange (#14364) docs: updated doc for create-react-app fix prefixCls of empty go to div (#14404) update snapshot (#14406) add radius on table-placeholder to fix table small size border clip (#14398) fix style of Input.Search with enterButton (#14397) ...

Fix the bug that radio onchange will be ovrride by radioGroup onchange

3585773

ztplz requested review from afc163 and zombieJ January 16, 2019 02:52

ztplz added 2 commits January 17, 2019 09:10

Update

80fa6d7

Remove unused comment

64104bb

Add tests

9f69814

zombieJ reviewed Jan 17, 2019

View reviewed changes

components/radio/__tests__/group.test.js Show resolved Hide resolved

zombieJ reviewed Jan 17, 2019

View reviewed changes

components/radio/radio.tsx Outdated Show resolved Hide resolved

Update

fc685f0

zombieJ merged commit 2d5b625 into ant-design:master Jan 18, 2019

ztplz deleted the radio branch January 18, 2019 10:10

chenshuai2144 changed the title ~~Fix the bug that radio onchange will be ovrride by radioGroup onchange~~ Fix the bug that radio onChange will be overide by radioGroup onChange Jan 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the bug that radio onChange will be overide by radioGroup onChange #14364

Fix the bug that radio onChange will be overide by radioGroup onChange #14364

ztplz commented Jan 16, 2019 •

edited

Loading

afc163 commented Jan 16, 2019

netlify bot commented Jan 16, 2019 •

edited

Loading

zombieJ commented Jan 16, 2019

ztplz commented Jan 17, 2019

codecov bot commented Jan 17, 2019 •

edited

Loading

codecov bot commented Jan 17, 2019 •

edited

Loading

codecov bot commented Jan 17, 2019

codecov bot commented Jan 17, 2019 •

edited

Loading

ztplz commented Jan 17, 2019

ztplz commented Jan 18, 2019

Fix the bug that radio onChange will be overide by radioGroup onChange #14364

Fix the bug that radio onChange will be overide by radioGroup onChange #14364

Conversation

ztplz commented Jan 16, 2019 • edited Loading

This is a ...

What's the background?

API Realization (Optional if not new feature)

What's the effect? (Optional if not new feature)

Changelog description (Optional if not new feature)

Self Check before Merge

Additional Plan? (Optional if not new feature)

afc163 commented Jan 16, 2019

netlify bot commented Jan 16, 2019 • edited Loading

zombieJ commented Jan 16, 2019

ztplz commented Jan 17, 2019

codecov bot commented Jan 17, 2019 • edited Loading

Codecov Report

codecov bot commented Jan 17, 2019 • edited Loading

Codecov Report

codecov bot commented Jan 17, 2019

Codecov Report

codecov bot commented Jan 17, 2019 • edited Loading

Codecov Report

ztplz commented Jan 17, 2019

ztplz commented Jan 18, 2019

ztplz commented Jan 16, 2019 •

edited

Loading

netlify bot commented Jan 16, 2019 •

edited

Loading

codecov bot commented Jan 17, 2019 •

edited

Loading

codecov bot commented Jan 17, 2019 •

edited

Loading

codecov bot commented Jan 17, 2019 •

edited

Loading