Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: circular dependency in Menu #17805

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Conversation

phthhieu
Copy link
Contributor

@phthhieu phthhieu commented Jul 22, 2019

#17803

Co-authored-by: Hau Dao [email protected]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #17803

💡 Background and solution

  • Move the shared dependecies to MenuContext.tsx

📝 Changelog

Language Changelog
🇺🇸 English No potential break changes
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Jul 22, 2019

Deploy preview for ant-design ready!

Built with commit 53ce816

https://deploy-preview-17805--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #17805 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17805   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files         267      268    +1     
  Lines        7457     7457           
  Branches     2084     2084           
=======================================
  Hits         7163     7163           
  Misses        292      292           
  Partials        2        2
Impacted Files Coverage Δ
components/menu/SubMenu.tsx 90% <ø> (ø) ⬆️
components/menu/index.tsx 97.54% <ø> (-0.02%) ⬇️
components/menu/MenuItem.tsx 94.44% <ø> (ø) ⬆️
components/menu/MenuContext.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78496da...53ce816. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #17805 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17805   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files         267      268    +1     
  Lines        7457     7457           
  Branches     2084     2084           
=======================================
  Hits         7163     7163           
  Misses        292      292           
  Partials        2        2
Impacted Files Coverage Δ
components/menu/SubMenu.tsx 90% <ø> (ø) ⬆️
components/menu/index.tsx 97.54% <ø> (-0.02%) ⬇️
components/menu/MenuItem.tsx 94.44% <ø> (ø) ⬆️
components/menu/MenuContext.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78496da...53ce816. Read the comment docs.

@afc163 afc163 changed the title Fix circular dependency in Menu fix: circular dependency in Menu Jul 22, 2019
@afc163 afc163 merged commit 5ded0ae into ant-design:master Jul 22, 2019
@phthhieu phthhieu deleted the fix_circular branch July 22, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular dependency: antd/lib/menu/index.js -> antd/lib/menu/MenuItem.js -> antd/lib/menu/index.js
2 participants