-
-
Notifications
You must be signed in to change notification settings - Fork 50.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: keep className given to expandIcon in Collapse component #19160
Fix: keep className given to expandIcon in Collapse component #19160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
Deploy preview for ant-design ready! Built with commit c8716e2 |
CI broken |
Codecov Report
@@ Coverage Diff @@
## master #19160 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 282 282
Lines 7548 7548
Branches 2110 2110
=======================================
Hits 7346 7346
Misses 201 201
Partials 1 1
Continue to review full report at Codecov.
|
Thanks |
🤔 This is a ...
🔗 Related issue link
fixes #19158
💡 Background and solution
use
classNames
method to add the`${prefixCls}-arrow`
to the existing classNames instead of overwriting them.📝 Changelog
Class name given to the
expandIcon
of theCollapse
component will be maintained so that might pose a change if users expected it to be lost.className
given toexpandIcon
inCollapse
componentCollapse
组件中expandIcon
自定义className
☑️ Self Check before Merge