site: update docs styles #39348
Merged
site: update docs styles #39348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
afc163
reviewed
Dec 7, 2022
afc163
reviewed
Dec 7, 2022
| typeof record.value === 'string' && | ||
| (record.value.startsWith('#') || record.value.startsWith('rgb')); | ||
| if (isColor) { | ||
| return <Badge color={record.value} text={record.value} />; |
There was a problem hiding this comment.
Badge 有点小，用上面那个 span 吧。
其实都是 6px，应该可以参考这种样式
There was a problem hiding this comment.
好，那我看看如何去修改。
可能我们真的需要一个方形色块组件 @MadCcc
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #39348 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 546 546
Lines 9366 9363 -3
Branches 2654 2652 -2
=========================================
- Hits 9366 9363 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
afc163
approved these changes
Dec 7, 2022
|
有演示页面看看么？ |
|
还是先用原来的吧，badge 没有阴影，白色就看不出来了 |
|
可以加个边框和阴影：https://ngx-colors.web.app/ |
|
那还是保持现状吧，不做修改 |
|
不是有宽度缩掉的问题么 |
哈哈，我是觉得改个这个感觉就没必要 PR 了。那我改一下，重新打开 :) |
Wxh16144
force-pushed
the
wuxh/site-custom-theme
branch
2 times, most recently
from
d6e9ef6 to
2f4bb65
Compare
codeball-ai-writer
bot
added
codeball:needs-careful-review
and removed
codeball:needs-review
labels
20 tasks
Wxh16144
added a commit
to Wxh16144-forks/ant-design
that referenced
this pull request
Sep 13, 2023
This reverts commit 4a80396. # Conflicts: # .dumi/theme/builtins/ColorChunk/index.tsx # .dumi/theme/builtins/TokenTable/index.tsx # docs/react/customize-theme.en-US.md # docs/react/customize-theme.zh-CN.md
afc163
added a commit
that referenced
this pull request
Sep 20, 2023
* chore: update blog style * Revert "chore: update blog style" This reverts commit afc0a1d. * Revert "site: update docs styles (#39348)" This reverts commit 4a80396. # Conflicts: # .dumi/theme/builtins/ColorChunk/index.tsx # .dumi/theme/builtins/TokenTable/index.tsx # docs/react/customize-theme.en-US.md # docs/react/customize-theme.zh-CN.md * chore: revert * chore：revert * chore: rename props * chore: update * chore(deps): add `dumi-plugin-color-chunk` plugin * chore: update docs * chore: update * Update package.json Co-authored-by: afc163 <[email protected]> Signed-off-by: 红 <[email protected]> * docs: pick #44945 Co-authored-by: RedJue <[email protected]> --------- Signed-off-by: 红 <[email protected]> Signed-off-by: 红 <[email protected]> Co-authored-by: MadCcc <[email protected]> Co-authored-by: afc163 <[email protected]> Co-authored-by: RedJue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
ref: #38463 (comment)
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge