Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mixed Chinese and English in Blog #46002

Merged
merged 1 commit into from
Nov 22, 2023
Merged

fix: mixed Chinese and English in Blog #46002

merged 1 commit into from
Nov 22, 2023

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Nov 21, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 无需纳入ChangeLog
🇨🇳 Chinese 无需纳入ChangeLog

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖[deprecated] Generated by Copilot at be16dda

This pull request fixes some issues with the blog post about CSS variables in Ant Design. It corrects a typo and adds English translations in the ./docs/blog/css-var-plan.en-US.md file, and restores the original Chinese content in the ./docs/blog/css-var-plan.zh-CN.md file.

🔍 Walkthrough

🤖[deprecated] Generated by Copilot at be16dda

  • Fix typo in CSS code example for background-color (link)
  • Translate Chinese text to English in docs/blog/css-var-plan.en-US.md for CSS Variables Isolation and CSS Variables Switching sections (link, link)
  • Revert translation changes in docs/blog/css-var-plan.zh-CN.md to keep Chinese text for CSS 变量隔离 and CSS 变量切换 sections (link, link)

Copy link

stackblitz bot commented Nov 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 21, 2023

Preview Is ready

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 321.57 KB
./dist/antd-with-locales.min.js 367.19 KB

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit be16dda:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

argos-ci bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Nov 21, 2023, 9:32 PM

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98e45b3) 100.00% compared to head (be16dda) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46002   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          700       700           
  Lines        11851     11851           
  Branches      3159      3159           
=========================================
  Hits         11851     11851           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan
Copy link
Member Author

话说这篇 blog 为啥放在 master?cssVar 不是月底才发布嘛

@MadCcc MadCcc merged commit 0cb771d into master Nov 22, 2023
99 checks passed
@MadCcc MadCcc deleted the fix-blog branch November 22, 2023 02:34
@MadCcc
Copy link
Member

MadCcc commented Nov 22, 2023

话说这篇 blog 为啥放在 master?cssVar 不是月底才发布嘛

因为这是预告性质的文章

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants