perf(PostgreSQL): improved support of connection strings, closes #893

antares-sql · Nov 8, 2024 · f0d312f · f0d312f
1 parent c97ade9
commit f0d312f
Show file tree

Hide file tree

Showing 10 changed files with 15 additions and 73 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -151,7 +151,6 @@
     "node-firebird": "~1.1.8",
     "node-loader": "~2.0.0",
     "pg": "~8.11.5",
-    "pg-connection-string": "~2.5.0",
     "pg-query-stream": "~4.2.3",
     "pgsql-ast-parser": "~7.2.1",
     "pinia": "~2.1.7",

diff --git a/src/common/interfaces/antares.ts b/src/common/interfaces/antares.ts
@@ -57,6 +57,7 @@ export interface ConnectionParams {
    cert?: string;
    key?: string;
    ca?: string;
+   connString?: string;
    untrustedConnection: boolean;
    ciphers?: string;
    ssh: boolean;

diff --git a/src/main/ipc-handlers/connection.ts b/src/main/ipc-handlers/connection.ts
@@ -26,6 +26,7 @@ export default (connections: Record<string, antares.Client>) => {
          user: conn.user,
          password: conn.password,
          readonly: conn.readonly,
+         connectionString: conn.connString,
          database: '',
          schema: '',
          databasePath: '',
@@ -122,6 +123,7 @@ export default (connections: Record<string, antares.Client>) => {
          password: conn.password,
          application_name: 'Antares SQL',
          readonly: conn.readonly,
+         connectionString: conn.connString,
          database: '',
          schema: '',
          databasePath: '',

diff --git a/src/main/libs/clients/PostgreSQLClient.ts b/src/main/libs/clients/PostgreSQLClient.ts
@@ -155,6 +155,7 @@ export class PostgreSQLClient extends BaseClient {
          host: this._params.host,
          port: this._params.port,
          user: this._params.user,
+         connectionString: this._params.connectionString,
          database: 'postgres' as string,
          password: this._params.password,
          ssl: null as ConnectionOptions

diff --git a/src/renderer/components/WorkspaceAddConnectionPanel.vue b/src/renderer/components/WorkspaceAddConnectionPanel.vue
@@ -67,7 +67,7 @@
                            <div class="column col-7 col-sm-12">
                               <input
                                  ref="pgString"
-                                 v-model="connection.pgConnString"
+                                 v-model="connection.connString"
                                  class="form-input"
                                  type="text"
                               >
@@ -502,8 +502,8 @@ const connection = ref({
    sshKey: '',
    sshPort: 22,
    sshKeepAliveInterval: 1800,
-   pgConnString: ''
-}) as Ref<ConnectionParams & { pgConnString: string }>;
+   connString: ''
+}) as Ref<ConnectionParams & { connString: string }>;
 
 const firstInput: Ref<HTMLInputElement> = ref(null);
 const isConnecting = ref(false);

diff --git a/src/renderer/components/WorkspaceEditConnectionPanel.vue b/src/renderer/components/WorkspaceEditConnectionPanel.vue
@@ -68,7 +68,7 @@
                         <div class="column col-7 col-sm-12">
                            <input
                               ref="pgString"
-                              v-model="localConnection.pgConnString"
+                              v-model="localConnection.connString"
                               class="form-input"
                               type="text"
                            >
@@ -502,7 +502,7 @@ const clients = [
 ];
 
 const firstInput: Ref<HTMLInputElement> = ref(null);
-const localConnection: Ref<ConnectionParams & { pgConnString: string }> = ref(null);
+const localConnection: Ref<ConnectionParams & { connString: string }> = ref(null);
 const isConnecting = ref(false);
 const isTesting = ref(false);
 const isAsking = ref(false);

diff --git a/src/renderer/ipc-api/Connection.ts b/src/renderer/ipc-api/Connection.ts
@@ -1,18 +1,15 @@
 import { ConnectionParams, IpcResponse } from 'common/interfaces/antares';
 import { ipcRenderer } from 'electron';
 
-import connStringConstruct from '../libs/connStringDecode';
 import { unproxify } from '../libs/unproxify';
 
 export default class {
-   static makeTest (params: ConnectionParams & { pgConnString?: string }): Promise<IpcResponse> {
-      const newParams = connStringConstruct(params) as ConnectionParams;
-      return ipcRenderer.invoke('test-connection', unproxify(newParams));
+   static makeTest (params: ConnectionParams & { connString?: string }): Promise<IpcResponse> {
+      return ipcRenderer.invoke('test-connection', unproxify(params));
    }
 
-   static connect (params: ConnectionParams & { pgConnString?: string }): Promise<IpcResponse> {
-      const newParams = connStringConstruct(params) as ConnectionParams;
-      return ipcRenderer.invoke('connect', unproxify(newParams));
+   static connect (params: ConnectionParams & { connString?: string }): Promise<IpcResponse> {
+      return ipcRenderer.invoke('connect', unproxify(params));
    }
 
    static abortConnection (uid: string): void {

diff --git a/src/renderer/libs/connStringDecode.ts b/src/renderer/libs/connStringDecode.ts
diff --git a/src/renderer/stores/workspaces.ts b/src/renderer/stores/workspaces.ts
@@ -147,7 +147,7 @@ export const useWorkspacesStore = defineStore('workspaces', {
          else
             this.selectedWorkspace = uid;
       },
-      async connectWorkspace (connection: ConnectionParams & { pgConnString?: string }, args?: {mode?: string; signal?: AbortSignal}) {
+      async connectWorkspace (connection: ConnectionParams & { connString?: string }, args?: {mode?: string; signal?: AbortSignal}) {
          this.workspaces = (this.workspaces as Workspace[]).map(workspace => workspace.uid === connection.uid
             ? {
                ...workspace,
@@ -427,7 +427,7 @@ export const useWorkspacesStore = defineStore('workspaces', {
 
          this.selectTab({ uid, tab: 0 });
       },
-      async switchConnection (connection: ConnectionParams & { pgConnString?: string }) {
+      async switchConnection (connection: ConnectionParams & { connString?: string }) {
          await Connection.disconnect(connection.uid);
          return this.connectWorkspace(connection, { mode: 'switch' });
       },