feat: enable virtual scrolling in code preview #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
changed the title
antfu
approved these changes
Jan 22, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the code preview to use the built-in virtual scrolling of CodeMirror. This is usefull when viewing large files like pre-bundled dependencies.
This PR also solved a minor issue where the diff toggle would not trigger the
watchEffect. If it's preferred, I'll make a seperate PR.Linked Issues
Additional context
This PR enables the searching module in CodeMirror. Usually the browser would be able to search through the code, but when virtual scrolling is enabled, this is not available.
The scrolling is linked on a percentage basis, preview below:
vite-plugin-inspect-scroll.mp4