fix: update @case-police-ignore regex #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnkarRuikar
commented
Nov 26, 2024
| @@ -11,7 +11,7 @@ export const DICT_FOLDER = dictDir | |||
| export const IGNORE_KEY = '@case-police-ignore' | |||
| export const DISABLE_KEY = '@case-police-disable' | |||
|
|
|||
| export const IGNORE_REGEX = /@case-police-ignore\s+(\S+)/g | |||
| export const IGNORE_REGEX = /@case-police-ignore\s+(.*)/g | |||
There was a problem hiding this comment.
@antfu This regex doesn't work with markdown comment <!-- @case-police-ignore App store -->. It matches App store --> and fails to ignore App store.
We need to find a better regex that would work with:
<!-- @case-police-ignore App store -->
<!-- @case-police-ignore App store,Github -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex needs to match multi-word terms.
I do not know what all the cases the
(\S+)matches currently. So taking a safe bet to use the same in the new regex: