feat: typescript.tsconfigPath array support #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Oct 31, 2023
src/configs/typescript.ts
Outdated
| @@ -36,6 +36,12 @@ export function typescript( | |||
| 'ts/unbound-method': 'error', | |||
| } | |||
|
|
|||
| const tsconfigPath = typeof tsc === 'string' && tsc.trim() | |||
There was a problem hiding this comment.
empty string check (or if spaces only)
There was a problem hiding this comment.
Suggested change
| const tsconfigPath = typeof tsc === 'string' && tsc.trim() | |
| const tsconfigPath = typeof tsc === 'string' ? ( | |
| tsc.trim() !== '' ? [tsc] : null | |
| ) : ... |
There was a problem hiding this comment.
I pushed a change. I think that setting tsconfigPath: " " should be a user error, and we shouldn't tolerant that implicitly.
There was a problem hiding this comment.
agree, thanks
just a habit to deal with user input - but here we have 'advanced' users
Dimava
reviewed
Oct 31, 2023
README.md
Outdated
| @@ -328,6 +328,8 @@ import antfu from '@antfu/eslint-config' | |||
| export default antfu({ | |||
| typescript: { | |||
| tsconfigPath: 'tsconfig.json', | |||
| // or if you have multiple tsconfigs | |||
| tsconfigPath: ['tsconfig.json', 'tsconfig.node.json'], | |||
There was a problem hiding this comment.
Copypasted code should "just work", so this line should be commented
It supports globs so I'd recommend adding "packages/*/tsconfig.json" here to imply that
And possibly "tsconfig.eslint.json" to imply you can make one especially for linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Multiple tsconfigs support
Linked Issues
close #305
Additional context