Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update astro plugin to v1.0 #492

Merged
merged 2 commits into from
Jun 2, 2024
Merged

Conversation

tinchoz49
Copy link
Contributor

Description

This PR updates the peerDependencies for Astro to the v1 stable version and tries to set up rules similar to what eslint-plugin-astro already provides by default.

Linked Issues

Additional context

Copy link

netlify bot commented Jun 1, 2024

Deploy Preview for melodious-froyo-4871f8 ready!

Name Link
🔨 Latest commit a4cda8f
🔍 Latest deploy log https://app.netlify.com/sites/melodious-froyo-4871f8/deploys/665c70189dc7060008320a00
😎 Deploy Preview https://deploy-preview-492--melodious-froyo-4871f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tinchoz49
Copy link
Contributor Author

@antfu The errors of the tests are because the astro configuration is validating the <script> tag of astro with the JavaScript rules and having an alert in the code produce the lint error. That's the correct behaviour. I'm going to modify the astro templates.

@antfu antfu changed the title chore: update astro feat: update astro plugin to v1.0 Jun 2, 2024
@antfu antfu merged commit 49a9d0c into antfu:main Jun 2, 2024
8 checks passed
@tinchoz49
Copy link
Contributor Author

thank you for the help @antfu ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants