docs: update readme for neovim setup #559
Conversation
✅ Deploy Preview for melodious-froyo-4871f8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| lspconfig.eslint.setup( | ||
| { | ||
| filetypes = { | ||
| "javascript", |
There was a problem hiding this comment.
Should we also add all the default filetypes?
lua =require("lspconfig.server_configurations.eslint").default_config.filetypes
" { "javascript", "javascriptreact", "javascript.jsx", "typescript", "typescriptreact", "typescript.tsx", "vue", "svelte", "astro" }We're only missing these two: javascript.jsx and typescript.tsx.
There was a problem hiding this comment.
svelte and yaml are missing too.
There was a problem hiding this comment.
Hi @thenbe Thanks for your review, as someone who is not doing a lot react. Can I ask why there's two filetype for tsx? E.g. The filetype I get from a tsx file is typescriptreact. Btw yaml is there.
There was a problem hiding this comment.
Seems like they're included in nvim-lspconfig because both variants are widely used: neovim/nvim-lspconfig#2419 (comment). FWIW I also get typescriptreact.
There was a problem hiding this comment.
Interesting, I have added these two and I would guess it's a legacy issue ( since I cannot find a clear explanation )?
There was a problem hiding this comment.
Yeah that's pretty much the same conclusion I reached, that they're included for legacy reasons.
* antfu/main: (128 commits) chore: update deps fix: migrate plugin eslint-comments (antfu#577) chore: release v2.25.1 fix: migrate to new vitest plugin, close antfu#576 chore: release v2.25.0 chore: update deps chore: typo (antfu#574) fix: default prettier `printWidth: 120` not work as expected (antfu#573) chore: release v2.24.1 docs: update readme for neovim setup (antfu#559) feat: upgrade `@typescript-eslint` to v8 stable chore: update snap chore: release v2.24.0 feat: upgrade `@types/eslint` chore: release v2.23.2 chore: update deps chore: release v2.23.1 chore: update deps chore: extract isInEditorEnv function (antfu#556) chore: update eslint-plugin-svelte (antfu#553) ...
Description
The pull request added neovim setup config that aligned with current vscode config in readme.
Linked Issues
Additional context