Add support for reading accelerometer data from FIFO #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @antirez - any chance for a quick review on this? Is basically all additive, and quite plain/simple stuff (imo) |
|
Hello @jonnor, very interested in this feature, thanks! I need to build a board with the chip again to test and merge. If I fail to do so in a timely fashion, I'll merge it without testing as I guess you tested it. Thank you. |
|
Thanks for having a look!
Yes I tested on the T-Watch. Many other ready-to-run devices from M5Stack
also have this accelerometer, like the M5Stick-C (at 20 USD). So that could
be a good alternative to a custom device for testing!
…On Tue, 21 May 2024, 10:42 Salvatore Sanfilippo, ***@***.***> wrote:
Hello @jonnor <https://github.com/jonnor>, very interested in this
feature, thanks! I need to build a board with the chip again to test and
merge. If I fail to do so in a timely fashion, I'll merge it without
testing as I guess you tested it. Thank you.
—
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALBALXM3KQ2JTPOKUK2M3ZDMCGRAVCNFSM6AAAAABF2QPX2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRSGA4DSMRQGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
It'd be great to get this merged, reading the FIFO is a super-useful feature! |
|
@antirez any chance of a merge for this? I am hoping to make some code examples for the T-Watch (in emlearn-micropython) that would make use of this driver and the FIFO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested working on the T-Watch 2020 V3 S3.
Takes around 40 milliseconds for read+decode for 100 samples at 100 Hz (1 block per second) - so utilizing 4% CPU.
Closes #3