Fix for #3588 -- Update root pom.xml for testing Antlr 4.11.1 #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaby76 thanks! |
rvrooman-codelogic
pushed a commit
to CodeLogicIncEngineering/grammars-v4-public-fork
that referenced
this pull request
Jul 27, 2023
…ntlr#3596) * Fix for antlr#3588 * Add comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #3588.
The version of the Antlr tool is specified directly in the root pom.xml. But the version of the runtime is specified indirectly with the antlr4test-maven-plugin.version. The plugin links with a version of runtime specified in the plugin here.
Consequently, when Dependabot updates the pom.xml, e.g., #3114 and #3462, it fails to take into consideration updating the version of the plugin, which must be specially released and published. The state for testing using the plugin is then inconsistent.
The newer test framework via trgen does not have this problem because it works from the version in the templates for both tool and runtime. The antlr4 tool is used, which not only downloads the Antlr .jar, but the java runtime. Even when running the compiled java program, it refers back to the one and only version string.
I am removing a .error file that I created for abb. The test plugin cannot deal with empty .errors files, so it has to be removed.
There's a problem with the XPath grammars. That is being fixed separately. #3595
The PR updates the support for testing with the plugin, until a time when people stop using it. Grammars that require the new features of Antlr 4.11.2 or more recent must be removed from the root pom.xml.