cpu_ibex: Fix wishbone address semantics #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While IBEX supplies addresses as they are, the [Wishbone spec][1] mandates that ADR_O be addressed in units of data port size, the lower bits being determined by SEL_O. A similar misrepresentation is present in Renode cosimulation integration, these fixes need to go in tandem. [1]: https://wishbone-interconnect.readthedocs.io/en/latest/02_interface.html#master-signals
DawidPietrykowski
force-pushed
the
wishbone-adr
branch
from
2ffe9eb to
ff0a00f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While IBEX supplies addresses as they are, the Wishbone spec mandates that ADR_O be addressed in units of data port size, the lower bits being determined by SEL_O. A similar misrepresentation is present in Renode cosimulation integration, these fixes need to go in tandem.
Upstream PR: renode/renode#727
The upstream change is intended to be used by CoreBlocks Open Source RISC-V CPU for integration with Renode. Currently it would need to be worked around by using extra conversion, like the suggested one here, but inverted.
Context: kuznia-rdzeni/coreblocks#778