Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find-up appears to be an undeclared runtime dependency #179

Closed
olivierlacan opened this issue Sep 9, 2021 · 3 comments · Fixed by #180
Closed

find-up appears to be an undeclared runtime dependency #179

olivierlacan opened this issue Sep 9, 2021 · 3 comments · Fixed by #180
Labels

Comments

@olivierlacan
Copy link

$ yarn run yarn-audit-fix
yarn run v1.22.0
$ /Users/olivierlacan/Development/ps/repo/node_modules/.bin/yarn-audit-fix
file:///Users/olivierlacan/Development/ps/repo/node_modules/yarn-audit-fix/target/es6/util.js:4
import { findUpSync, pathExistsSync } from 'find-up';
         ^^^^^^^^^^
SyntaxError: Named export 'findUpSync' not found. The requested module 'find-up' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'find-up';
const { findUpSync, pathExistsSync } = pkg;

    at ModuleJob._instantiate (internal/modules/esm/module_job.js:97:21)
    at async ModuleJob.run (internal/modules/esm/module_job.js:142:20)
    at async Loader.import (internal/modules/esm/loader.js:182:24)
    at async Object.loadESM (internal/process/esm_loader.js:68:5)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Not quite familiar with these errors but shouldn't find-up be a runtime dependency?

import { findUpSync, pathExistsSync } from 'find-up'

It's only listed in devDependencies:

"find-up": "^6.0.0",

@antongolub
Copy link
Owner

Good catch, thanks!

antongolub added a commit that referenced this issue Sep 10, 2021
antongolub added a commit that referenced this issue Sep 10, 2021
github-actions bot pushed a commit that referenced this issue Sep 10, 2021
## [7.0.2](v7.0.1...v7.0.2) (2021-09-10)

### Bug Fixes

* **package:** add missed prod dep `find-up` ([6fa6d8f](6fa6d8f)), closes [#179](#179)
@antongolub
Copy link
Owner

🎉 This issue has been resolved in version 7.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@olivierlacan
Copy link
Author

Thanks for the super quick resolution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants