-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md PowerShell Script #54
Update README.md PowerShell Script #54
Conversation
@antonmedv This PR has been sitting for a couple weeks; are there any modifications you're waiting on that are preventing this from being merged? |
Let’s fix upstream issue. |
What if we remove the association with #30 from this PR and merge this documentation change (that way the issue won't be closed when this is merged). Progress on the upstream issues is slow, and I'd like the README to provide a Powershell script that works in the meantime -- the currently provided script will fail for new users. |
Yes, lets do it |
Okay, I've removed the closing association 👍 |
} | ||
``` | ||
See [issues/30](https://github.com/antonmedv/llama/issues/30) for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still in pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I kept that in the actual README so that when users read the setup docs they can understand that the script is actually a workaround for an upstream issue (all that info is in #30), that's something that could be removed once the issue is closed and the script is updated again. I just removed the association in the PR text that would close the issue once it's merged.
Context:
Changes (Functional):
Additional Notes & Tech Debt:
Relevant GitHub items: