Use newer Starlark APIs #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
single_file will be replaced by allow_single_file. ctx.action will be replaced by ctx.actions.run and ctx.actions.run_shell.
cloud-robotics-github-robot
pushed a commit
to googlecloudrobotics/core
that referenced
this pull request
Feb 21, 2019
This addresses use of single_file, and pulls in some changes to rules_python from upstream. This is a contribution to #2. I have also sent a pull request for bazel_rules: antonovvk/bazel_rules#2 There are many other failures, including: - java_grpc_library.bzl from grpc/grpc-java - protobuf.bzl from google/protobuf - rules_go - references to genfiles (this will be unified with `bin`). Change-Id: Ic6548244f0906cdbd53aed16017191b6db8cd553 GitOrigin-RevId: daa70bc
|
Can you merge this please? |
|
Oops, sorry, I thought the author would do it after approval and forgot to check it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
single_file will be replaced by allow_single_file.
ctx.action will be replaced by ctx.actions.run and
ctx.actions.run_shell.