Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review verbosity of log messages #4

Closed
antoninbas opened this issue Nov 4, 2019 · 1 comment
Closed

Review verbosity of log messages #4

antoninbas opened this issue Nov 4, 2019 · 1 comment
Assignees
@abhiraut

Comments

@antoninbas
Copy link
Contributor

Some log messages are probably using a default verbosity value of 0, but should only be logged at higher verbosity levels. For example, I was looking at some recent agent logs for e2 tests and saw the following:

I1104 18:52:26.096285       1 monitor.go:143] Updating agent monitor CRD &{{ } {antrea-agent-6st6m   /apis/clusterinformation.crd.antrea.io/v1beta1/antreaagentinfos/antrea-agent-6st6m c3277bfc-bbed-4325-8f17-59364d5b0530 415142 1 2019-11-04 18:51:26 +0000 UTC <nil> <nil> map[] map[] [] nil []  []} UKNOWN {Pod kube-system antrea-agent-6st6m    } {Node  k8s-node-master    } [10.10.0.0/24] { br-int map[0:3 10:3 100:1 110:2 20:3 30:2 31:6 40:2 50:1 60:1 70:3 80:3 90:1]} 0 []}
I1104 18:53:26.102658       1 monitor.go:143] Updating agent monitor CRD &{{ } {antrea-agent-6st6m   /apis/clusterinformation.crd.antrea.io/v1beta1/antreaagentinfos/antrea-agent-6st6m c3277bfc-bbed-4325-8f17-59364d5b0530 415250 2 2019-11-04 18:51:26 +0000 UTC <nil> <nil> map[] map[] [] nil []  []} UKNOWN {Pod kube-system antrea-agent-6st6m    } {Node  k8s-node-master    } [10.10.0.0/24] { br-int map[0:3 10:3 100:1 110:2 20:3 30:2 31:6 40:2 50:1 60:1 70:3 80:3 90:1]} 0 []}
I1104 18:54:26.109453       1 monitor.go:143] Updating agent monitor CRD &{{ } {antrea-agent-6st6m   /apis/clusterinformation.crd.antrea.io/v1beta1/antreaagentinfos/antrea-agent-6st6m c3277bfc-bbed-4325-8f17-59364d5b0530 415250 2 2019-11-04 18:51:26 +0000 UTC <nil> <nil> map[] map[] [] nil []  []} UKNOWN {Pod kube-system antrea-agent-6st6m    } {Node  k8s-node-master    } [10.10.0.0/24] { br-int map[0:3 10:3 100:1 110:2 20:3 30:2 31:6 40:2 50:1 60:1 70:3 80:3 90:1]} 0 []}
I1104 18:55:26.113783       1 monitor.go:143] Updating agent monitor CRD &{{ } {antrea-agent-6st6m   /apis/clusterinformation.crd.antrea.io/v1beta1/antreaagentinfos/antrea-agent-6st6m c3277bfc-bbed-4325-8f17-59364d5b0530 415250 2 2019-11-04 18:51:26 +0000 UTC <nil> <nil> map[] map[] [] nil []  []} UKNOWN {Pod kube-system antrea-agent-6st6m    } {Node  k8s-node-master    } [10.10.0.0/24] { br-int map[0:3 10:3 100:1 110:2 20:3 30:2 31:6 40:2 50:1 60:1 70:3 80:3 90:1]} 0 []}

I think @abhiraut wanted to take a look at this.
abhiraut added a commit that referenced this issue Nov 4, 2019
@abhiraut
Update logging levels
16478d8 
Set an appropriate logging level in various
modules such that debug level logs are not
logged at default level.

Closes: #4
@abhiraut abhiraut mentioned this issue Nov 4, 2019
Closed
@abhiraut
Copy link
Contributor

fixed by bb4b7d3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhiraut abhiraut

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update logging levels antrea-io/antrea
2 participants
@abhiraut @antoninbas