[Flow Aggregator] Remove originalExporterAddress and originalObservationDomainId #2361
Conversation
zyiou
added
the
area/flow-visibility/aggregator
|
/test-all |
Codecov Report
@@ Coverage Diff @@
## main #2361 +/- ##
===========================================
+ Coverage 41.89% 59.78% +17.88%
===========================================
Files 145 283 +138
Lines 18072 22088 +4016
===========================================
+ Hits 7572 13206 +5634
+ Misses 9818 7474 -2344
- Partials 682 1408 +726
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zyiou
added
the
area/flow-visibility
|
/test-all |
| if fa.templateIDv4Expv6, err = fa.createAndSendTemplate(false, true); err != nil { | ||
| return err | ||
| } | ||
| if fa.templateIDv6Expv4, err = fa.createAndSendTemplate(true, false); err != nil { |
There was a problem hiding this comment.
I feel like even with 2 templates only, the helper function may still be a good idea?
|
/test-all |
|
@srikartati could you take another look at this? |
pkg/flowaggregator/flowaggregator.go
Outdated
| // and original exporter IP could belong to different IP families. | ||
| if fa.templateIDv4Expv4, err = fa.createAndSendTemplate(false, false); err != nil { | ||
| // Currently, we send two templates for IPv4 and IPv6 regardless of the IP families supported by cluster | ||
| fa.createAndSendTemplate(true) |
There was a problem hiding this comment.
why does this need to be called two times? is this an expected line?
There was a problem hiding this comment.
Thanks for noticing this. This should be removed.
This commit removes originalExporterIPv4Address, originalExporterIPv6Address and originalObservationDomainId from flow aggregator and related templates for these fields. It also bumps go-ipfix to v0.5.4. fixes antrea-io#2336 Signed-off-by: zyiou <[email protected]>
|
/test-all |
|
/test-ipv6-e2e |
|
e2e test failed at |
|
/test-ipv6-e2e |
This commit removes
originalExporterIPv4Address,originalExporterIPv6AddressandoriginalObservationDomainIdfrom flow aggregator and related templates for these fields.It also bumps go-ipfix to v0.5.4.
fixes #2336