Unify config name and format #2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2843 +/- ##
===========================================
+ Coverage 40.90% 60.25% +19.35%
===========================================
Files 158 284 +126
Lines 19539 23470 +3931
===========================================
+ Hits 7992 14142 +6150
+ Misses 10798 7827 -2971
- Partials 749 1501 +752
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tnqn
reviewed
Sep 27, 2021
cmd/antrea-controller/config.go
Outdated
| ServiceCIDR string `yaml:"serviceCIDR,omitempty"` | ||
| SecondaryServiceCIDR string `yaml:"secondaryServiceCIDR,omitempty"` | ||
| ServiceCIDR string `yaml:"serviceCIDR,omitempty"` | ||
| ServiceCIDRv6 string `yaml:"ServiceCIDRv6,omitempty"` |
There was a problem hiding this comment.
Suggested change
| ServiceCIDRv6 string `yaml:"ServiceCIDRv6,omitempty"` | |
| ServiceCIDRv6 string `yaml:"serviceCIDRv6,omitempty"` |
cmd/antrea-controller/options.go
Outdated
| netutils "k8s.io/utils/net" | ||
| "net" |
ksamoray
force-pushed
the
nodeipam-config
branch
2 times, most recently
from
eca2316 to
9a1ab8d
Compare
Use same naming and format convention for for NodeIPAM as it is for other Antrea features. Fixes: antrea-io#2839 Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
nodeipam-config
branch
from
9a1ab8d to
24b3a02
Compare
tnqn
approved these changes
Sep 28, 2021
|
/test-all |
antoninbas
pushed a commit
that referenced
this pull request
Oct 20, 2022
Use same naming and format convention for for NodeIPAM as it is for other Antrea features. Fixes: #2839 Signed-off-by: Kobi Samoray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use same naming and format convention for for NodeIPAM as it is for
other Antrea features.
Fixes: #2839