Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP NotForReview Multicast] Improve kind e2e tests for multicast #3944

Closed
wants to merge 2 commits into from
Closed

[WIP NotForReview Multicast] Improve kind e2e tests for multicast #3944

wants to merge 2 commits into from

Conversation

ceclinux
Copy link
Contributor

Try to fix the multicast testbed issue in #3922 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022 •
edited by codecov bot
Loading

Codecov Report

Merging #3944 (485a2b2) into main (0dceb75) will decrease coverage by 2.20%.
The diff coverage is n/a.

❗ Current head 485a2b2 differs from pull request most recent head 467c9a2. Consider uploading reports for the commit 467c9a2 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3944      +/-   ##
==========================================
- Coverage   63.17%   60.96%   -2.21%     
==========================================
  Files         388      383       -5     
  Lines       55129    54953     -176     
==========================================
- Hits        34825    33500    -1325     
- Misses      17731    18989    +1258     
+ Partials     2573     2464     -109
Flag Coverage Δ
integration-tests 34.53% <ø> (+0.10%) ⬆️
kind-e2e-tests 51.89% <ø> (+2.55%) ⬆️
unit-tests 43.96% <ø> (-0.60%) ⬇️
Impacted Files Coverage Δ
pkg/ipfix/ipfix_intermediate.go 0.00% <0.00%> (-90.91%) ⬇️
pkg/ipfix/ipfix_collector.go 0.00% <0.00%> (-83.34%) ⬇️
...trollers/multicluster/label_identity_controller.go 0.00% <0.00%> (-81.73%) ⬇️
pkg/cni/client.go 0.00% <0.00%> (-77.78%) ⬇️
pkg/flowaggregator/certificate.go 0.00% <0.00%> (-75.53%) ⬇️
...rs/multicluster/commonarea/clusterinfo_importer.go 0.00% <0.00%> (-74.51%) ⬇️
...s/multicluster/label_identity_export_controller.go 0.00% <0.00%> (-72.93%) ⬇️
pkg/flowaggregator/exporter/utils.go 0.00% <0.00%> (-72.73%) ⬇️
...kg/agent/flowexporter/connections/conntrack_ovs.go 0.00% <0.00%> (-70.91%) ⬇️
...uster/commonarea/acnp_resourceimport_controller.go 0.00% <0.00%> (-69.83%) ⬇️
... and 92 more

@ceclinux ceclinux force-pushed the multicast_kind_fix branch 7 times, most recently from f53c318 to 1ba767f Compare July 4, 2022 04:25
@ceclinux
Copy link
Contributor Author

ceclinux commented Jul 4, 2022

/test-multicast-e2e

1 similar comment
@ceclinux
Copy link
Contributor Author

ceclinux commented Jul 4, 2022

/test-multicast-e2e

@ceclinux ceclinux force-pushed the multicast_kind_fix branch from 80380a1 to e2e772d Compare July 4, 2022 07:18
@ceclinux
Copy link
Contributor Author

ceclinux commented Jul 4, 2022

/test-multicast-e2e

@ceclinux ceclinux force-pushed the multicast_kind_fix branch from e2e772d to c1de40a Compare July 4, 2022 07:43
@ceclinux
Copy link
Contributor Author

ceclinux commented Jul 4, 2022

/test-multicast-e2e

@ceclinux ceclinux force-pushed the multicast_kind_fix branch from c1de40a to a821792 Compare July 4, 2022 08:10
@ceclinux
Copy link
Contributor Author

ceclinux commented Jul 4, 2022

/test-multicast-e2e

@ceclinux ceclinux force-pushed the multicast_kind_fix branch from a821792 to a35a87e Compare July 4, 2022 08:55
@ceclinux
Copy link
Contributor Author

ceclinux commented Jul 4, 2022

/test-multicast-e2e

@ceclinux ceclinux force-pushed the multicast_kind_fix branch from a35a87e to bfd625e Compare July 4, 2022 09:23
@ceclinux
Copy link
Contributor Author

ceclinux commented Jul 4, 2022

/test-multicast-e2e

1 similar comment
@ceclinux
Copy link
Contributor Author

ceclinux commented Jul 4, 2022

/test-multicast-e2e

@ceclinux ceclinux force-pushed the multicast_kind_fix branch from bfd625e to ee201ba Compare July 4, 2022 10:13
@ceclinux
Copy link
Contributor Author

ceclinux commented Jul 4, 2022

/test-multicast-e2e

@ceclinux ceclinux force-pushed the multicast_kind_fix branch from ee201ba to e5e52b5 Compare July 4, 2022 10:22
@ceclinux
Copy link
Contributor Author

ceclinux commented Jul 4, 2022

/test-multicast-e2e

@ceclinux ceclinux force-pushed the multicast_kind_fix branch from e5e52b5 to 4737e20 Compare July 4, 2022 10:31
@ceclinux
Copy link
Contributor Author

ceclinux commented Jul 4, 2022

/test-multicast-e2e

@ceclinux ceclinux force-pushed the multicast_kind_fix branch from 4737e20 to d07a810 Compare July 4, 2022 14:11
@ceclinux
Copy link
Contributor Author

ceclinux commented Jul 4, 2022

/test-multicast-e2e

@ceclinux ceclinux force-pushed the multicast_kind_fix branch from d07a810 to 9a935b9 Compare July 4, 2022 14:31
@ceclinux ceclinux force-pushed the multicast_kind_fix branch 4 times, most recently from 3b2e29c to 613eece Compare July 5, 2022 08:40
@ceclinux
Copy link
Contributor Author

/test-multicast-e2e

@ceclinux ceclinux force-pushed the multicast_kind_fix branch from 613eece to 67560f7 Compare August 14, 2022 21:47
@ceclinux
Copy link
Contributor Author

/test-multicast-e2e

@ceclinux ceclinux force-pushed the multicast_kind_fix branch from 67560f7 to 6068c06 Compare August 15, 2022 03:38
@ceclinux
Copy link
Contributor Author

/test-multicast-e2e

@ceclinux ceclinux force-pushed the multicast_kind_fix branch from 6068c06 to eceee36 Compare August 15, 2022 10:13
@ceclinux
Copy link
Contributor Author

/test-multicast-e2e

@ceclinux ceclinux force-pushed the multicast_kind_fix branch from eceee36 to 01e8fe6 Compare August 15, 2022 13:45
@ceclinux
Copy link
Contributor Author

/test-multicast-e2e

4 similar comments
@ceclinux
Copy link
Contributor Author

/test-multicast-e2e

@ceclinux
Copy link
Contributor Author

/test-multicast-e2e

@ceclinux
Copy link
Contributor Author

/test-multicast-e2e

@ceclinux
Copy link
Contributor Author

/test-multicast-e2e

@ceclinux
Copy link
Contributor Author

/test-multicast-e2e

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 10, 2023
@antrea-io antrea-io deleted a comment from github-actions bot Jan 10, 2023
@ceclinux ceclinux removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 10, 2023
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 11, 2023
@ceclinux ceclinux removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 11, 2023
@antrea-io antrea-io deleted a comment from github-actions bot Apr 11, 2023
@github-actions
Copy link
Contributor

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 11, 2023
@github-actions github-actions bot closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ceclinux @codecov-commenter