[WIP Multicast] use real external node in multicast e2e #4034

ceclinux · 2022-07-19T10:29:37Z

No description provided.

ceclinux · 2022-07-19T10:32:26Z

ci/jenkins/test.sh

@@ -120,6 +125,9 @@ if [[ "${IP_MODE}" != "${DEFAULT_IP_MODE}" && "${IP_MODE}" != "ipv6" && "${IP_MO
    echoerr "--ip-mode must be ipv4, ipv6 or ds"
    exit 1
 fi
+
+EXTERNAL_HOSTS_CONFIG_PATH="ci/jenkins/external-hosts-config.yml"


TODO: rm this line and passing as argument when running in jenkins

ceclinux · 2022-07-19T10:32:55Z

ci/jenkins/test.sh

    else
-        go test -v antrea.io/antrea/test/e2e --logs-export-dir `pwd`/antrea-test-logs --provider remote -timeout=100m --prometheus
+        go test -run=TestMulticast -v antrea.io/antrea/test/e2e --logs-export-dir `pwd`/antrea-test-logs --external-hosts-config-path "$EXTERNAL_HOSTS_CONFIG_PATH" --provider remote -timeout=20m --prometheus


TODO: revert this line before merging

ceclinux · 2022-07-19T10:39:50Z

/test-multicast-e2e

wenyingd · 2022-07-19T10:57:41Z

test/e2e/multicast_test.go

+					// If multicast traffic is sent from an external host, the multicast route will be configured on the sender node because the sender node
+					// and external host connect to the same gateway.
+					// If sender-receivers are located in different nodes, the receivers should configure corresponding inbound multicast routes.
+					if (mc.externalSender && receiverIdx == senderNodeIdx && receiverMulticastInterface == externalHostIface) || (!mc.externalSender && receiverIdx != senderNodeIdx) {


Do have such cases that both sender and receiver are external host? If not, this should never hit for the condition "(mc.externalSender && receiverIdx == senderNodeIdx"？

I changed name from senderNodeIdx to multiMcastIfaceNodeIdx. External host and node with multiple multicast interfaces connects to the same gateway.Therefore it should be mcast route in multi-mcast interface node with iif externalIface.

wenyingd · 2022-07-19T11:17:42Z

test/e2e/multicast_test.go

+	t.Run("testMulticastWithNoEncap", func(t *testing.T) {
+		runMulticastTestCases(t, data, nodeMulticastInterfaces, true)
+	})
+	t.Run("testMulticastWithEncap", func(t *testing.T) {


This is copied from #3947? Maybe remove it to keep this patch clean?

wenyingd · 2022-07-19T11:19:15Z

test/e2e/multicast_test.go


 func TestMulticast(t *testing.T) {
+	skipIfNoExternalHosts(t)


I think we can have a single case dedicated for traffic with external host, and skip the single case if no external hosts is existing in the cluster, rather than skip all multicast test cases

wenyingd · 2022-07-19T11:31:56Z

test/e2e/framework.go

@@ -154,6 +155,15 @@ type ClusterNode struct {
 	os               string
 }

+type ExternalHost struct {
+	Name       string                  `name`


Use a complete json expression like json:"name"

ceclinux · 2022-07-19T14:57:36Z

/test-multicast-e2e

codecov · 2022-07-19T15:05:14Z

Codecov Report

Merging #4034 (cc6d877) into main (231b09d) will increase coverage by 3.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4034      +/-   ##
==========================================
+ Coverage   64.40%   67.63%   +3.23%     
==========================================
  Files         293      296       +3     
  Lines       43658    43763     +105     
==========================================
+ Hits        28116    29599    +1483     
+ Misses      13253    11855    -1398     
- Partials     2289     2309      +20

Flag	Coverage Δ
integration-tests	`36.04% <ø> (?)`
kind-e2e-tests	`50.45% <ø> (-0.31%)`	⬇️
unit-tests	`44.18% <ø> (+<0.01%)`	⬆️

see 59 files with indirect coverage changes

ceclinux · 2022-07-20T08:57:51Z

/test-multicast-e2e

ceclinux · 2022-07-20T09:33:17Z

/test-multicast-e2e

ceclinux · 2022-07-20T10:06:48Z

/test-multicast-e2e

ceclinux · 2022-07-20T10:21:09Z

/test-multicast-e2e

ceclinux · 2022-07-20T10:50:20Z

/test-multicast-e2e

ceclinux · 2022-07-20T11:04:22Z

/test-multicast-e2e

ceclinux · 2022-07-20T11:04:50Z

/test-multicast-e2e

ceclinux · 2022-07-20T11:37:32Z

/test-multicast-e2e

ceclinux · 2022-07-20T11:38:17Z

/test-multicast-e2e

ceclinux · 2022-07-21T02:33:57Z

/test-multicast-e2e

ceclinux · 2022-07-21T03:08:59Z

/test-multicast-e2e

ceclinux · 2022-07-21T03:44:46Z

/test-multicast-e2e

ceclinux · 2023-01-09T13:03:42Z

/test-multicast-e2e

github-actions · 2023-08-22T00:03:23Z

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

ceclinux commented Jul 19, 2022

View reviewed changes

wenyingd reviewed Jul 19, 2022

View reviewed changes

ceclinux force-pushed the real_external_host_multicast_e2e branch from 77a909f to 42160ad Compare July 19, 2022 14:55

ceclinux force-pushed the real_external_host_multicast_e2e branch from 42160ad to 423af98 Compare July 20, 2022 08:56

ceclinux force-pushed the real_external_host_multicast_e2e branch from 423af98 to d37cd89 Compare July 20, 2022 09:33

ceclinux force-pushed the real_external_host_multicast_e2e branch from d37cd89 to 73c1ee4 Compare July 20, 2022 10:06

ceclinux force-pushed the real_external_host_multicast_e2e branch from 73c1ee4 to 31a00ae Compare July 20, 2022 10:20

ceclinux force-pushed the real_external_host_multicast_e2e branch from 31a00ae to 43e3a47 Compare July 20, 2022 10:45

ceclinux force-pushed the real_external_host_multicast_e2e branch from 43e3a47 to 8797023 Compare July 20, 2022 11:03

ceclinux force-pushed the real_external_host_multicast_e2e branch from 8797023 to 838a6b0 Compare July 20, 2022 11:36

ceclinux force-pushed the real_external_host_multicast_e2e branch from 838a6b0 to 857565d Compare July 21, 2022 02:33

[Multicast] use real external node in multicast e2e

cc6d877

ceclinux force-pushed the real_external_host_multicast_e2e branch from 857565d to cc6d877 Compare July 21, 2022 02:35

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 20, 2022

antrea-io deleted a comment from github-actions bot Oct 20, 2022

github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 21, 2022

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2023

antrea-io deleted a comment from github-actions bot Apr 10, 2023

github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 11, 2023

ceclinux changed the title ~~[Multicast] use real external node in multicast e2e~~ [WIP Multicast] use real external node in multicast e2e May 23, 2023

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 22, 2023

github-actions bot closed this Nov 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP Multicast] use real external node in multicast e2e #4034

[WIP Multicast] use real external node in multicast e2e #4034

ceclinux commented Jul 19, 2022

ceclinux Jul 19, 2022

ceclinux Jul 19, 2022

ceclinux commented Jul 19, 2022

wenyingd Jul 19, 2022

ceclinux Jul 21, 2022

wenyingd Jul 19, 2022

ceclinux Jul 21, 2022

wenyingd Jul 19, 2022

ceclinux Jul 21, 2022

wenyingd Jul 19, 2022

ceclinux Jul 21, 2022

ceclinux commented Jul 19, 2022

codecov bot commented Jul 19, 2022 •

edited

Loading

ceclinux commented Jul 20, 2022

ceclinux commented Jul 20, 2022

ceclinux commented Jul 20, 2022

ceclinux commented Jul 20, 2022

ceclinux commented Jul 20, 2022

ceclinux commented Jul 20, 2022

ceclinux commented Jul 20, 2022

ceclinux commented Jul 20, 2022

ceclinux commented Jul 20, 2022

ceclinux commented Jul 21, 2022

ceclinux commented Jul 21, 2022

ceclinux commented Jul 21, 2022

ceclinux commented Jan 9, 2023

github-actions bot commented Aug 22, 2023

[WIP Multicast] use real external node in multicast e2e #4034

[WIP Multicast] use real external node in multicast e2e #4034

Conversation

ceclinux commented Jul 19, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ceclinux commented Jul 19, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ceclinux commented Jul 19, 2022

codecov bot commented Jul 19, 2022 • edited Loading

Codecov Report

ceclinux commented Jul 20, 2022

ceclinux commented Jul 20, 2022

ceclinux commented Jul 20, 2022

ceclinux commented Jul 20, 2022

ceclinux commented Jul 20, 2022

ceclinux commented Jul 20, 2022

ceclinux commented Jul 20, 2022

ceclinux commented Jul 20, 2022

ceclinux commented Jul 20, 2022

ceclinux commented Jul 21, 2022

ceclinux commented Jul 21, 2022

ceclinux commented Jul 21, 2022

ceclinux commented Jan 9, 2023

github-actions bot commented Aug 22, 2023

codecov bot commented Jul 19, 2022 •

edited

Loading