[SecondaryNetwork] Require resourceName annotations for SRIOV #6999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "k8s.v1.cni.cncf.io/resourceName" annotation should be provided for all SRIOV NetworkAttachmentDefinitions. Otherwise, it is impossible to guarantee that the right device type is allocated for a given interface. Signed-off-by: Antonin Bas <[email protected]>
|
References: |
|
Depends on #6922 for testing |
antoninbas
added
the
area/secondary-network
jianjuns
approved these changes
Feb 15, 2025
|
|
Thanks @wenqiq, I appreciate you running the tests for this PR! |
|
/skip-all |
antoninbas
deleted the
secondary-network-require-resourceName-for-sriov-interfaces
branch
antoninbas
added
the
action/release-note
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "k8s.v1.cni.cncf.io/resourceName" annotation should be provided for all SRIOV NetworkAttachmentDefinitions. Otherwise, it is impossible to guarantee that the right device type is allocated for a given interface.