[FlowAggregator] Accept configurations with no collector / sink #7006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the FlowAggregator would crash if the configuration didn't enable at least one collector (e.g., the IPFIX collector). While it was probably introduced to help identify misconfigurations easily, it seems like an unnecessary restriction. We should be able to deploy the FlowAggregator in such a way that IPFIX records are still received from Agents (and metrics are incremented), while discarding aggregated / proxied data instead of exporting it. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added
the
action/release-note
antoninbas
added
the
area/flow-visibility/aggregator
luolanzone
reviewed
Feb 20, 2025
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the FlowAggregator would crash if the configuration didn't enable at least one collector (e.g., the IPFIX collector). While it was probably introduced to help identify misconfigurations easily, it seems like an unnecessary restriction. We should be able to deploy the FlowAggregator in such a way that IPFIX records are still received from Agents (and metrics are incremented), while discarding aggregated / proxied data instead of exporting it.