Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve d3-array type locked issue #6607

Open
wants to merge 3 commits into
base: v5
Choose a base branch
from

Conversation

BQXBQX
Copy link
Contributor

@BQXBQX BQXBQX commented Feb 14, 2025

Checklist
  • npm test passes
  • commit message follows commit guidelines
Description of change
  • 将 vendor 版本设置为 ^1.0.8,解决了 @types/d3-array 锁死的问题
image

Copy link

Walkthrough

This pull request addresses type issues related to the d3-array package. It updates the vendor version to ^1.0.8 to resolve the problem with @types/d3-array. The changes involve type casting to any in several test files and source files to handle type mismatches.

Changes

Files Summary
__tests__/plots/static/barley-line-trail.ts, __tests__/plots/static/income-statement-by-region-interval-custom.ts Type casting to any for resolving type issues in test files.
package.json Updated @antv/vendor version to ^1.0.8.
src/interaction/legendHighlight.ts, src/runtime/layout.ts, src/transform/bin.ts Added type casting and updated imports to handle type issues.

@BQXBQX BQXBQX changed the title chore: resolve d3-array type issues chore: resolve d3-array type locked issues Feb 14, 2025
@BQXBQX BQXBQX changed the title chore: resolve d3-array type locked issues chore: resolve d3-array type locked issue Feb 14, 2025
@coveralls
Copy link

coveralls commented Feb 14, 2025

Pull Request Test Coverage Report for Build 13333934281

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.701%

Totals Coverage Status
Change from base Build 13321315805: 0.0%
Covered Lines: 10603
Relevant Lines: 11855

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants