Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat：缩放画布时支持隐藏除keyShape外的元素 #1324

Merged
merged 6 commits into from
Mar 20, 2020
Merged

feat：缩放画布时支持隐藏除keyShape外的元素 #1324

merged 6 commits into from
Mar 20, 2020

Conversation

baizn
Copy link
Contributor

@baizn baizn commented Mar 18, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change
  1. zoom-canvas 时支持隐藏非 keyShape 元素，支持配置：
  • enableOptimize：是否开启，默认为false；
  • optimizeZoom：enableOptimize 为 true 时生效，表示当缩放比例小于该值时，自动隐藏非 keyShape 元素，默认值为 0.7。
  1. 修复 changeData 问题，调用changeData方法后，隐藏的边又显示出来，隐藏的节点则可以保持隐藏状态 #1323

@baizn baizn requested review from Yanyan-Wang and dxq613 March 18, 2020 09:55
@lgtm-com
Copy link

lgtm-com bot commented Mar 18, 2020

This pull request introduces 1 alert when merging 79fa3c6 into 511a305 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 19, 2020

This pull request introduces 1 alert when merging 1de31bb into 37bda3f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

accesslint[bot]
accesslint bot suggested changes Mar 20, 2020
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

docs/manual/introduction.en.md

<img src='https://gw.alipayobjects.com/mdn/rms_f8c6a0/afts/img/A*dsXsSpgynmUAAAAAAAAAAABkARQnAQ' width=400>
<img src='https://gw.alipayobjects.com/mdn/rms_f8c6a0/afts/img/A*hzfaSrAj0jkAAAAAAAAAAABkARQnAQ' width=400>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

docs/manual/introduction.en.md
<img src='https://gw.alipayobjects.com/mdn/rms_f8c6a0/afts/img/A*dsXsSpgynmUAAAAAAAAAAABkARQnAQ' width=400>
<img src='https://gw.alipayobjects.com/mdn/rms_f8c6a0/afts/img/A*hzfaSrAj0jkAAAAAAAAAAABkARQnAQ' width=400>

<img src='https://gw.alipayobjects.com/mdn/rms_f8c6a0/afts/img/A*7uu-T7kp6uUAAAAAAAAAAABkARQnAQ' width=400>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

docs/manual/introduction.zh.md

> 由于值班同学的时间和精力有限，**G6 图可视化交流二群** 中的问题我们会不定期回复。欢迎对 G6 感兴趣的同学加入到答疑中来，非常感谢！

<img src='https://gw.alipayobjects.com/mdn/rms_f8c6a0/afts/img/A*hzfaSrAj0jkAAAAAAAAAAABkARQnAQ' width=400>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

docs/manual/introduction.zh.md

<img src='https://gw.alipayobjects.com/mdn/rms_f8c6a0/afts/img/A*hzfaSrAj0jkAAAAAAAAAAABkARQnAQ' width=400>

<img src='https://gw.alipayobjects.com/mdn/rms_f8c6a0/afts/img/A*7uu-T7kp6uUAAAAAAAAAAABkARQnAQ' width=400>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

@lgtm-com
Copy link

lgtm-com bot commented Mar 20, 2020

This pull request introduces 1 alert when merging 5308544 into 37bda3f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@baizn baizn merged commit 241b5ef into master Mar 20, 2020
@baizn baizn deleted the combo-20200318 branch March 20, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accesslint accesslint[bot] accesslint[bot] requested changes

@Yanyan-Wang Yanyan-Wang Awaiting requested review from Yanyan-Wang

@dxq613 dxq613 Awaiting requested review from dxq613

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@baizn