Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed loop edges positioning and labels for loop edges #388

Merged
merged 1 commit into from
May 10, 2022

Conversation

makstakeda
Copy link
Contributor

On latest master, if I create 3 loop edges on single node, labels/edges were positioned on top of each other.

The part about loop edges was working fine on previous version and seems to be broken on 2.6.5. So, I did the check and it seems to be the issue is with removal of deepMix usage on the latest master for processing edges (restored it).
If edge is loop, label position processed based on loop distance and initial offset based on default value for poly.
Did some rework on conditions and added the tests.

BEFORE:
image

AFTER:
image

There is the animation showing dynamically changed loop value. Label keeps its positioning based on loop.
Peek 2022-05-05 11-03

@pomelo-nwu
Copy link
Member

@makstakeda Thank you for finding and solving this problem

@pomelo-nwu pomelo-nwu merged commit 9289f5c into antvis:master May 10, 2022
@pomelo-nwu
Copy link
Member

@makstakeda @antv/[email protected] and fix this problem: #391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants