Specify required version of tslib ^2.0.0 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version + features of typescript used to compile this lib means that tslib needs to be at version 2.0.0 minimum. Because `antvis/algorithm` doesn't specify an explicit version, it is not guaranteed that developers receive the necessary version. This causes the following error at import time: ``` ./node_modules/@antv/algorithm/es/gaddi.js Attempted import error: '__spreadArray' is not exported from 'tslib'. ``` You can see here all the other projects updating their tslib dependencies similarly in the references to this PR: microsoft/tslib#133 This relates to antvis/G6#2702 and antvis/G6#2713 it is likely necessary, but may not be sufficient, to fix those reported issues. There could be other `antvis` packages with the same issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version + features of typescript used to compile this lib means that tslib needs to be at version 2.0.0 minimum.
Because
antvis/algorithmdoesn't specify an explicit version, it is not guaranteed that developers receive the necessary version.This causes the following error at import time:
You can see here all the other projects updating their tslib dependencies similarly in the references to this PR: microsoft/tslib#133
This relates to
antvis/G6#2702
and
antvis/G6#2713
it is likely necessary, but may not be sufficient, to fix those reported issues. There could be other
antvispackages with the same issue.