Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stats): add 'not_bold' option to stats card #1468

Merged
merged 2 commits into from
Sep 17, 2022

Conversation

rickstaa
Copy link
Collaborator

Implements #1426. @anuraghazra I'm not sure if we want to implement this feature in the main branch but I wanted to give people a pull request they can use might they want this feature.

@vercel
Copy link

vercel bot commented Nov 22, 2021

@rickstaa is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

api/index.js Outdated Show resolved Hide resolved
@rickstaa rickstaa force-pushed the add_stats_card_bold_option branch from b3c4d8a to 76c5f94 Compare November 22, 2021 18:04
@rickstaa rickstaa force-pushed the add_stats_card_bold_option branch from 76c5f94 to 051dfad Compare November 22, 2021 18:11
@rickstaa
Copy link
Collaborator Author

Text_bold=undefined

undefined

text_bold=false

not bold

text_bold=true

not bold

@rickstaa
Copy link
Collaborator Author

In the current form, the title is kept bold. We can however also change that behaviour. @anubhav217 did not provide a detailed explanation in #1426.

@rickstaa
Copy link
Collaborator Author

rickstaa commented Nov 22, 2021

Given that the header is implemented here:

font: 600 18px 'Segoe UI', Ubuntu, Sans-Serif;

I think it is not worth it since it will complicate the codebase.

@rickstaa
Copy link
Collaborator Author

@anuraghazra I think this can be safely merged.

@rickstaa rickstaa force-pushed the add_stats_card_bold_option branch from a7cff00 to 8315028 Compare September 17, 2022 11:31
@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Base: 95.18% // Head: 95.20% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (8315028) compared to base (eacc3cd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1468      +/-   ##
==========================================
+ Coverage   95.18%   95.20%   +0.01%     
==========================================
  Files          22       22              
  Lines         789      792       +3     
  Branches      216      219       +3     
==========================================
+ Hits          751      754       +3     
  Misses         33       33              
  Partials        5        5              
Impacted Files Coverage Δ
api/index.js 90.47% <ø> (ø)
src/getStyles.js 56.25% <ø> (ø)
src/cards/stats-card.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rickstaa rickstaa merged commit f9b9015 into anuraghazra:master Sep 17, 2022
@rickstaa rickstaa deleted the add_stats_card_bold_option branch September 17, 2022 11:32
infinity-plus pushed a commit to infinity-plus/github-readme-stats that referenced this pull request Sep 24, 2022
devantler pushed a commit to devantler/github-readme-stats that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we have an option to style the text like say make it bold or change the font?
2 participants